[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <563B3942.90305@huawei.com>
Date: Thu, 5 Nov 2015 19:10:58 +0800
From: Xishi Qiu <qiuxishi@...wei.com>
To: Laura Abbott <labbott@...hat.com>
CC: zhong jiang <zhongjiang@...wei.com>,
Laura Abbott <labbott@...oraproject.org>,
Kees Cook <keescook@...omium.org>,
"Catalin Marinas" <catalin.marinas@....com>,
Will Deacon <will.deacon@....com>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
LKML <linux-kernel@...r.kernel.org>,
Ard Biesheuvel <ard.biesheuvel@...aro.org>,
Mark Rutland <mark.rutland@....com>
Subject: Re: [PATCH 2/2] arm64: Allow changing of attributes outside of modules
On 2015/11/5 2:12, Laura Abbott wrote:
> On 11/03/2015 06:59 PM, zhong jiang wrote:
>>
>> Hi Laura
>>
>> This patch seems vaild, but I didn't feel very reasonable.
>> Because of the large page to make TLB performance better, just
>> split it if it is necessary.therefore, I think the first thing
>> we try to keep it, if they fail ,and then to split.
>>
>
> I'm not quite sure I understand the request. We know we are going
> to have to have something mapped at page size granularity so we
> are going to have to break down the larger mappings no matter
> what. Can you explain a bit more where you think we could try to
> keep the larger mappings?
>
Hi Laura,
He means like this, if the range is aligned with large page, we
need not to split it, just change the flag.
I have one more question.
alloc_init_pud()
...
if (!pud_none(old_pud))
...
memblock_free(table, PAGE_SIZE);
...
Here we will free the memory from pmd page, so why not free
more memory from 512 pte pages, if the 512 old pmds are not none?
Thanks,
Xishi Qiu
> At least two things I noticed looking at this again though:
> - This only splits the start address. If the range happens
> to overlap a pud/pmd this won't work. I'll address that in v2
> - We're always flushing the TLB even if nothing changed. Was
> this what you were referring to?
>
>
>> thanks
>> zhongjiang
>>
>>
>
> Thanks,
> Laura
>
>
> .
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists