linux-kernel - Re: [PATCH 0/4] watchdog: address various races (CPU hotplug, timer expiry)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151105144600.GE209762@redhat.com>
Date:	Thu, 5 Nov 2015 09:46:00 -0500
From:	Don Zickus <dzickus@...hat.com>
To:	Ulrich Obergfell <uobergfe@...hat.com>
Cc:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	atomlin@...hat.com
Subject: Re: [PATCH 0/4] watchdog: address various races (CPU hotplug, timer
 expiry)

On Tue, Nov 03, 2015 at 04:20:57PM +0100, Ulrich Obergfell wrote:
> This patch set addresses various races in relation to CPU hotplug
> and a race in relation to watchdog timer expiry. I discovered the
> corner cases during code inspection. I haven't seen any of these
> issues occur in practice.

Series looks fine to me.  I have run some local panic tests with no
problems, along with modifying various values and everything seems fine.

Acked-by: Don Zickus <dzickus@...hat.com>

> 
> Ulrich Obergfell (4):
>   watchdog: avoid race between lockup detector suspend/resume and CPU
>     hotplug
>   watchdog: avoid races between /proc handlers and CPU hotplug
>   watchdog: remove {get|put}_online_cpus() from
>     watchdog_{park|unpark}_threads()
>   watchdog: fix race between proc_watchdog_thresh() and
>     watchdog_timer_fn()
> 
>  kernel/watchdog.c | 20 +++++++++++++++-----
>  1 file changed, 15 insertions(+), 5 deletions(-)
> 
> -- 
> 1.7.11.7
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/