linux-kernel - Re: [RFC PATCH 2/7] spi: sunxi: remove redundant "depends on RESET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151105150529.GN18409@sirena.org.uk>
Date:	Thu, 5 Nov 2015 15:05:29 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Philipp Zabel <p.zabel@...gutronix.de>,
	linux-spi@...r.kernel.org
Subject: Re: [RFC PATCH 2/7] spi: sunxi: remove redundant "depends on
 RESET_CONTROLLER"

On Thu, Nov 05, 2015 at 09:32:15PM +0900, Masahiro Yamada wrote:

> For compile test, right, "depends on RESET_CONTROLLER" is
> redundant in the first place.

> For run-time on real SoCs,the driver failed at the following point
> without the reset-controller sub-system.

Your changelog needs to say this clearly, right now what it's saying
clearly doesn't correspond to what the change does.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)