linux-kernel - Re: [PATCH 2/2] ASoC: codecs: Add da7218 codec driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151105152736.GO18409@sirena.org.uk>
Date:	Thu, 5 Nov 2015 15:27:36 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Adam Thomson <Adam.Thomson.Opensource@...semi.com>
Cc:	Liam Girdwood <lgirdwood@...il.com>,
	Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.com>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>, alsa-devel@...a-project.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	Support Opensource <support.opensource@...semi.com>
Subject: Re: [PATCH 2/2] ASoC: codecs: Add da7218 codec driver

On Thu, Nov 05, 2015 at 10:43:19AM +0000, Adam Thomson wrote:

> +/* ALC */
> +static void da7218_alc_calib(struct snd_soc_codec *codec)
> +{
> +	struct da7218_priv *da7218 = snd_soc_codec_get_drvdata(codec);
> +	u8 calib_ctrl;
> +	int i = 0;
> +	bool calibrated = false;
> +
> +	/* Bypass cache so it saves current settings */
> +	regcache_cache_bypass(da7218->regmap, true);

What ensures that nothing else is running at the same time this is?  

> +static int da7218_mic_lvl_det_sw_put(struct snd_kcontrol *kcontrol,
> +				     struct snd_ctl_elem_value *ucontrol)
> +{

Why is this a user visible control?

> +	/* Default all mixers off */
> +	snd_soc_write(codec, DA7218_DROUTING_OUTDAI_1L, 0);
> +	snd_soc_write(codec, DA7218_DROUTING_OUTDAI_1R, 0);
> +	snd_soc_write(codec, DA7218_DROUTING_OUTDAI_2L, 0);
> +	snd_soc_write(codec, DA7218_DROUTING_OUTDAI_2R, 0);
> +	snd_soc_write(codec, DA7218_DROUTING_OUTFILT_1L, 0);
> +	snd_soc_write(codec, DA7218_DROUTING_OUTFILT_1R, 0);
> +	snd_soc_write(codec, DA7218_DROUTING_ST_OUTFILT_1L, 0);
> +	snd_soc_write(codec, DA7218_DROUTING_ST_OUTFILT_1R, 0);

We generally just use the device defaults, why change them?

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)