linux-kernel - Re: [RFC] ext4: remove unused page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151105154227.GD23628@quack.suse.cz>
Date:	Thu, 5 Nov 2015 16:42:27 +0100
From:	Jan Kara <jack@...e.cz>
To:	yalin wang <yalin.wang2010@...il.com>
Cc:	tytso@....edu, adilger.kernel@...ger.ca,
	linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC] ext4: remove unused page_idx

On Wed 04-11-15 16:03:39, yalin wang wrote:
> Signed-off-by: yalin wang <yalin.wang2010@...il.com>
> ---
>  fs/ext4/readpage.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> ignore my previous patch

Ah, ignore my previous review ;) But next time it is good to reply to that
patch that you are withdrawing it to so that people can immediately see it.

This patch look good to me. You can add:

Reviewed-by: Jan Kara <jack@...e.com>

								Honza

> 
> diff --git a/fs/ext4/readpage.c b/fs/ext4/readpage.c
> index 5dc5e95..2cc2760 100644
> --- a/fs/ext4/readpage.c
> +++ b/fs/ext4/readpage.c
> @@ -135,7 +135,6 @@ int ext4_mpage_readpages(struct address_space *mapping,
>  			 unsigned nr_pages)
>  {
>  	struct bio *bio = NULL;
> -	unsigned page_idx;
>  	sector_t last_block_in_bio = 0;
>  
>  	struct inode *inode = mapping->host;
> @@ -157,7 +156,7 @@ int ext4_mpage_readpages(struct address_space *mapping,
>  	map.m_len = 0;
>  	map.m_flags = 0;
>  
> -	for (page_idx = 0; nr_pages; page_idx++, nr_pages--) {
> +	for (; nr_pages; nr_pages--) {
>  		int fully_mapped = 1;
>  		unsigned first_hole = blocks_per_page;
>  
> -- 
> 1.9.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/