linux-kernel - Re: [PATCH 3/4] dm verity: add support for forward error correction

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201511060627.6n5B3CI9%fengguang.wu@intel.com>
Date:	Fri, 6 Nov 2015 06:06:17 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Sami Tolvanen <samitolvanen@...gle.com>
Cc:	kbuild-all@...org, Mikulas Patocka <mpatocka@...hat.com>,
	Mandeep Baines <msb@...omium.org>,
	Will Drewry <wad@...omium.org>,
	Alasdair Kergon <agk@...hat.com>,
	Mike Snitzer <snitzer@...hat.com>, dm-devel@...hat.com,
	linux-kernel@...r.kernel.org, Kees Cook <keescook@...omium.org>,
	Mark Salyzyn <salyzyn@...gle.com>,
	Sami Tolvanen <samitolvanen@...gle.com>
Subject: Re: [PATCH 3/4] dm verity: add support for forward error correction

Hi Sami,

[auto build test WARNING on: dm/for-next]
[also build test WARNING on: v4.3 next-20151105]

url:    https://github.com/0day-ci/linux/commits/Sami-Tolvanen/dm-verity-clean-up-duplicate-hashing-code/20151105-124458
base:   https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git for-next
config: s390-allyesconfig (attached as .config)
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=s390 

All warnings (new ones prefixed by >>):

   drivers/md/dm-verity.c: In function 'verity_fec_decode_rsb':
>> drivers/md/dm-verity.c:812:1: warning: 'verity_fec_decode_rsb' uses dynamic stack allocation
    }
    ^

vim +/verity_fec_decode_rsb +812 drivers/md/dm-verity.c

   796		if (r < 0)
   797			return r;
   798	
   799		r = verity_hash(v, io_hash_desc(v, io), io->fec_buf,
   800				1 << v->data_dev_block_bits, io_real_digest(v, io));
   801		if (unlikely(r < 0))
   802			return r;
   803	
   804		if (memcmp(io_real_digest(v, io), io_want_digest(v, io),
   805				v->digest_size)) {
   806			DMERR_LIMIT("%s: FEC %llu: failed to correct (%d erasures)",
   807				    v->data_dev->name, (unsigned long long)rsb, neras);
   808			return -1;
   809		}
   810	
   811		return 0;
 > 812	}
   813	
   814	static int verity_fec_bv_copy(struct dm_verity *v, struct dm_verity_io *io,
   815				      u8 *data, size_t len)
   816	{
   817		BUG_ON(io->fec_pos + len > 1 << v->data_dev_block_bits);
   818		memcpy(data, &io->fec_buf[io->fec_pos], len);
   819		io->fec_pos += len;
   820		return 0;

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (38647 bytes)