lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 4 Nov 2015 21:39:30 -0500 From: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com> To: Bob Liu <bob.liu@...cle.com> Cc: xen-devel@...ts.xen.org, linux-kernel@...r.kernel.org, roger.pau@...rix.com, felipe.franciosi@...rix.com, axboe@...com, avanzini.arianna@...il.com, rafal.mielniczuk@...rix.com, jonathan.davies@...rix.com, david.vrabel@...rix.com Subject: Re: [PATCH v4 09/10] xen/blkfront: make persistent grants per-queue On Mon, Nov 02, 2015 at 12:21:45PM +0800, Bob Liu wrote: > Make persistent grants per-queue/ring instead of per-device, so that we can > drop the 'dev_lock' and get better scalability. And what is the performance value for this? How much better scalability do you get with this? .. snip.. > @@ -1010,6 +1002,23 @@ static void blkif_free_ring(struct blkfront_ring_info *rinfo) > } > } > > + /* Remove all persistent grants */ Missing full stop. > + if (!list_empty(&rinfo->grants)) { > + list_for_each_entry_safe(persistent_gnt, n, > + &rinfo->grants, node) { > + list_del(&persistent_gnt->node); > + if (persistent_gnt->gref != GRANT_INVALID_REF) { > + gnttab_end_foreign_access(persistent_gnt->gref, > + 0, 0UL); > + rinfo->persistent_gnts_c--; > + } > + if (info->feature_persistent) > + __free_page(pfn_to_page(persistent_gnt->pfn)); > + kfree(persistent_gnt); > + } > + } > + BUG_ON(rinfo->persistent_gnts_c != 0); > + -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists