linux-kernel - Re: [PATCH] md/raid5: remove redundant check in stripe_add_to_batch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87vb9g9cw7.fsf@notabene.neil.brown.name>
Date:	Fri, 06 Nov 2015 11:42:32 +1100
From:	Neil Brown <neilb@...e.com>
To:	Roman Gushchin <klamm@...dex-team.ru>, linux-kernel@...r.kernel.org
Cc:	Roman Gushchin <klamm@...dex-team.ru>, linux-raid@...r.kernel.org
Subject: Re: [PATCH] md/raid5: remove redundant check in stripe_add_to_batch_list()

On Mon, Nov 02 2015, Roman Gushchin wrote:

> The stripe_add_to_batch_list() function is called only if
> stripe_can_batch() returned true, so there is no need for double check.
>
> Signed-off-by: Roman Gushchin <klamm@...dex-team.ru>
> Cc: Neil Brown <neilb@...e.com>
> Cc: linux-raid@...r.kernel.org
> ---
>  drivers/md/raid5.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
> index 45933c1..f829ebc 100644
> --- a/drivers/md/raid5.c
> +++ b/drivers/md/raid5.c
> @@ -768,8 +768,6 @@ static void stripe_add_to_batch_list(struct r5conf *conf, struct stripe_head *sh
>  	int hash;
>  	int dd_idx;
>  
> -	if (!stripe_can_batch(sh))
> -		return;
>  	/* Don't cross chunks, so stripe pd_idx/qd_idx is the same */
>  	tmp_sec = sh->sector;
>  	if (!sector_div(tmp_sec, conf->chunk_sectors))
> -- 
> 2.4.3

applied, thanks.

(for future reference, public mailing lists like linux-raid aren't
usually mentioned on a 'Cc:' line in a patch.
Documentation/SubmittingPatches suggests:

  If a person has had the opportunity to comment on a patch, but has not
  provided such comments, you may optionally add a "Cc:" tag to the patch.
  This is the only tag which might be added without an explicit action by the
  person it names - but it should indicate that this person was copied on the
  patch.  This tag documents that potentially interested parties
  have been included in the discussion.

so it is primarily for third-party individuals
)

Thanks,
NeilBrown

Download attachment "signature.asc" of type "application/pgp-signature" (819 bytes)