[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-id: <001001d1186b$358b6470$a0a22d50$@samsung.com>
Date: Fri, 06 Nov 2015 11:14:49 +0300
From: Pavel Fedin <p.fedin@...sung.com>
To: 'Krzysztof Kozlowski' <k.kozlowski@...sung.com>,
devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: 'Rob Herring' <robh+dt@...nel.org>,
'Pawel Moll' <pawel.moll@....com>,
'Mark Rutland' <mark.rutland@....com>,
'Ian Campbell' <ijc+devicetree@...lion.org.uk>,
'Kumar Gala' <galak@...eaurora.org>,
'Kukjin Kim' <kgene@...nel.org>
Subject: RE: [PATCH v6 1/4] Documentation: dt-bindings: Describe SROMc
configuration
Hello!
> > +- samsung,srom-timing : array of 6 integers, specifying bank timings in the
> > + following order: Tacp, Tcah, Tcoh, Tacc, Tcos, Tacs.
> > + Each value is specified in cycles and has the following
> > + meaning and valid range:
> > + Tacp : Page mode access cycle at Page mode (0 - 15)
> > + Tcah : Address holding time after CSn (0 - 15)
> > + Tcoh : Chip selection hold on OEn (0 - 15)
> > + Tacc : Access cycle (0 - 32)
>
> All of the manuals have error here. Probably it can be either: 1-32 or
> 0-31. I would bet on 0-31, what do you think?
Damn, everything starts from 0, so i automatically put '0 - 32'. The actual time, however, varies from 1 to 32, but the value is
from 0 to 31, i. e. <time> - 1
What shall we do? Just document this, or adjust the code to take number of cycles and subtract 1? To tell the truth, i'm already
sick of these small fixups, and i would prefer just to fix documentation.
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists