linux-kernel - Re: [PATCH] hwmon/applesmc: Fix uninitialized variables warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151106004502.GB32106@roeck-us.net>
Date:	Thu, 5 Nov 2015 16:45:02 -0800
From:	Guenter Roeck <linux@...ck-us.net>
To:	Shuah Khan <shuahkh@....samsung.com>
Cc:	rydberg@...math.org, jdelvare@...e.de, lm-sensors@...sensors.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hwmon/applesmc: Fix uninitialized variables warnings

On Thu, Nov 05, 2015 at 03:39:27PM -0700, Shuah Khan wrote:
> Fix the following "maybe used uninitialized" warnings by
> initializing the variables to keep the compiler quiet.
> There is no "used uninitialized" in this case.
> 
>   CC [M]  drivers/hwmon/applesmc.o
> drivers/hwmon/applesmc.c: In function ‘applesmc_init_smcreg’:
> drivers/hwmon/applesmc.c:595:43: warning: ‘right_light_sensor’
> may be used uninitialized in this function [-Wmaybe-uninitialized]
>   s->num_light_sensors = left_light_sensor + right_light_sensor;
>                                            ^
> drivers/hwmon/applesmc.c:540:26: note: ‘right_light_sensor’ was
> declared here
>   bool left_light_sensor, right_light_sensor;
>                           ^
> drivers/hwmon/applesmc.c:595:43: warning: ‘left_light_sensor’ may
> be used uninitialized in this function [-Wmaybe-uninitialized]
>   s->num_light_sensors = left_light_sensor + right_light_sensor;
>                                            ^
> drivers/hwmon/applesmc.c:540:7: note: ‘left_light_sensor’ was
> declared here
>   bool left_light_sensor, right_light_sensor;
>        ^
> 
> Signed-off-by: Shuah Khan <shuahkh@....samsung.com>

Applied.

Thanks,
Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/