linux-kernel - Re: [PATCH] mmc: pxamci: fix read-only gpio detection polarity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 6 Nov 2015 10:08:50 +0100
From:	Ulf Hansson <ulf.hansson@...aro.org>
To:	Robert Jarzmik <robert.jarzmik@...e.fr>
Cc:	linux-mmc <linux-mmc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"# 4.0+" <stable@...r.kernel.org>
Subject: Re: [PATCH] mmc: pxamci: fix read-only gpio detection polarity

On 5 November 2015 at 20:46, Robert Jarzmik <robert.jarzmik@...e.fr> wrote:
> The commit converting pxamci to slot-gpio API inverted the logic of the
> read-only gpio. Fix it by inverting the logic again.
>
> Fixes: fd546ee6a7dc ("mmc: pxamci: fix card detect with slot-gpio API")
> Signed-off-by: Robert Jarzmik <robert.jarzmik@...e.fr>
> Cc: stable@...r.kernel.org

Thanks, applied for fixes!

Kind regards
Uffe

> ---
>  drivers/mmc/host/pxamci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/pxamci.c b/drivers/mmc/host/pxamci.c
> index 8cadd74e8407..ce08896b9d69 100644
> --- a/drivers/mmc/host/pxamci.c
> +++ b/drivers/mmc/host/pxamci.c
> @@ -805,7 +805,7 @@ static int pxamci_probe(struct platform_device *pdev)
>                 goto out;
>         } else {
>                 mmc->caps |= host->pdata->gpio_card_ro_invert ?
> -                       MMC_CAP2_RO_ACTIVE_HIGH : 0;
> +                       0 : MMC_CAP2_RO_ACTIVE_HIGH;
>         }
>
>         if (gpio_is_valid(gpio_cd))
> --
> 2.1.4
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/