linux-kernel - Re: [PATCH v2 1/2] ASoC: codec: Inno codec driver for RK3036 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151106092842.GT18409@sirena.org.uk>
Date:	Fri, 6 Nov 2015 09:28:42 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Shunqian Zheng <zhengsq@...k-chips.com>
Cc:	robh+dt@...nel.org, pawel.moll@....com, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
	heiko@...ech.de, lgirdwood@...il.com, perex@...ex.cz,
	tiwai@...e.com, benzh@...omium.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	linux-rockchip@...ts.infradead.org
Subject: Re: [PATCH v2 1/2] ASoC: codec: Inno codec driver for RK3036 SoC

On Fri, Nov 06, 2015 at 04:15:37PM +0800, Shunqian Zheng wrote:
> On 2015年11月06日 00:13, Mark Brown wrote:
> >On Thu, Nov 05, 2015 at 05:53:13PM +0800, Shunqian Zheng wrote:

> >This looks like a simple boolean control rather than an enum - it looks
> >like it's just turning antipop on and off.

> It is a boolean control, but it takes 2 bits -- the value of "on" is b10 and
> b01 for "off".
> So I try to use VALUE_ENUM.

The presentation of the control to userspace needs to be a Switch, this
is probably going to need you to code something custom.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)