linux-kernel - Re: [PATCH] hpet: Delete an unnecessary check before unregister_sysctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <563C9060.2000400@ladisch.de>
Date:	Fri, 6 Nov 2015 12:34:56 +0100
From:	Clemens Ladisch <clemens@...isch.de>
To:	SF Markus Elfring <elfring@...rs.sourceforge.net>,
	Arnd Bergmann <arnd@...db.de>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	kernel-janitors@...r.kernel.org,
	Julia Lawall <julia.lawall@...6.fr>
Subject: Re: [PATCH] hpet: Delete an unnecessary check before
	unregister_sysctl_table()

SF Markus Elfring wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Thu, 5 Nov 2015 21:32:42 +0100
>
> The unregister_sysctl_table() function tests whether its argument is NULL
> and then returns immediately. Thus the test around the call is not needed.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>

Acked-by: Clemens Ladisch <clemens@...isch.de>

> ---
>  drivers/char/hpet.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/char/hpet.c b/drivers/char/hpet.c
> index 240b6cf..fe511e9 100644
> --- a/drivers/char/hpet.c
> +++ b/drivers/char/hpet.c
> @@ -1069,8 +1069,7 @@ static int __init hpet_init(void)
>
>  	result = acpi_bus_register_driver(&hpet_acpi_driver);
>  	if (result < 0) {
> -		if (sysctl_header)
> -			unregister_sysctl_table(sysctl_header);
> +		unregister_sysctl_table(sysctl_header);
>  		misc_deregister(&hpet_misc);
>  		return result;
>  	}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/