linux-kernel - Re: [PATCH 6/7] regulator: hisilicon: Add hi655x pmic voltage regulator driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201511061928.lSImC8GL%fengguang.wu@intel.com>
Date:	Fri, 6 Nov 2015 19:47:21 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Chen Feng <puck.chen@...ilicon.com>
Cc:	kbuild-all@...org, w.f@...wei.com, sameo@...ux.intel.com,
	lee.jones@...aro.org, linux-kernel@...r.kernel.org,
	lgirdwood@...il.com, broonie@...nel.org, robh+dt@...nel.org,
	pawel.moll@....com, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
	puck.chen@...ilicon.com, joro@...tes.org,
	iommu@...ts.linux-foundation.org, haojian.zhuang@...aro.org,
	devicetree@...r.kernel.org, xuwei5@...ilicon.com,
	xuyiping@...ilicon.com, kong.kongxinwei@...ilicon.com,
	z.liuxinliang@...ilicon.com, yudongbin@...ilicon.com,
	weidong2@...ilicon.com, saberlily.xia@...ilicon.com,
	haojian.zhuang@...look.com, leo.yan@...aro.org,
	linuxarm@...wei.com, dan.zhao@...ilicon.com,
	peter.panshilin@...ilicon.com, qijiwen@...ilicon.com
Subject: Re: [PATCH 6/7] regulator: hisilicon: Add hi655x pmic voltage
 regulator driver

Hi Chen,

[auto build test ERROR on regulator/for-next]
[also build test ERROR on v4.3 next-20151106]

url:    https://github.com/0day-ci/linux/commits/Chen-Feng/Add-Support-for-Hi6220-PMIC-Hi6553-MFD-Core/20151105-215603
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next
config: arm-allmodconfig (attached as .config)
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=arm 

All error/warnings (new ones prefixed by >>):

   drivers/regulator/hi6220-mtcmos.c: In function 'hi6220_mtcmos_enable':
>> drivers/regulator/hi6220-mtcmos.c:105:2: error: expected ';' before 'return'
     return ret;
     ^
>> drivers/regulator/hi6220-mtcmos.c:106:1: warning: no return statement in function returning non-void [-Wreturn-type]
    }
    ^
--
   drivers/regulator/hi655x-regulator.c: In function 'hi655x_disable':
>> drivers/regulator/hi655x-regulator.c:65:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
     struct hi655x_regulator_ctrl_regs *ctrl_regs = &regulator->ctrl_regs;
     ^
   drivers/regulator/hi655x-regulator.c: In function 'hi655x_get_voltage':
   drivers/regulator/hi655x-regulator.c:81:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
     struct hi655x_regulator_vset_regs *vset_regs = &regulator->vset_regs;
     ^
   drivers/regulator/hi655x-regulator.c: In function 'hi655x_set_voltage':
   drivers/regulator/hi655x-regulator.c:101:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
     struct hi655x_regulator_vset_regs *vset_regs = &regulator->vset_regs;
     ^
   drivers/regulator/hi655x-regulator.c: In function 'hi655x_regulator_probe':
   drivers/regulator/hi655x-regulator.c:189:6: warning: unused variable 'ret' [-Wunused-variable]
     int ret = 0;
         ^

vim +65 drivers/regulator/hi655x-regulator.c

    49		struct hi655x_regulator_ctrl_regs *ctrl_regs = &regulator->ctrl_regs;
    50	
    51		ret = regmap_update_bits(rdev->regmap, ctrl_regs->enable_reg,
    52					 regulator->ctrl_mask, regulator->ctrl_mask);
    53		return ret;
    54	}
    55	
    56	static int hi655x_disable(struct regulator_dev *rdev)
    57	{
    58		int ret = 0;
    59		struct hi655x_regulator *regulator = rdev_get_drvdata(rdev);
    60	
    61		if (!regulator) {
    62			pr_err("get driver data error!\n");
    63			return -ENODEV;
    64		}
  > 65		struct hi655x_regulator_ctrl_regs *ctrl_regs = &regulator->ctrl_regs;
    66	
    67		ret = regmap_update_bits(rdev->regmap, ctrl_regs->disable_reg,
    68					 regulator->ctrl_mask, regulator->ctrl_mask);
    69		return ret;
    70	}
    71	
    72	static int hi655x_get_voltage(struct regulator_dev *rdev)
    73	{

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (53757 bytes)