linux-kernel - RE: [PATCH 2/2] ASoC: codecs: Add da7218 codec driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2E89032DDAA8B9408CB92943514A0337D460CA3D@SW-EX-MBX01.diasemi.com>
Date:	Fri, 6 Nov 2015 11:53:00 +0000
From:	"Opensource [Adam Thomson]" <Adam.Thomson.Opensource@...semi.com>
To:	Mark Brown <broonie@...nel.org>,
	"Opensource [Adam Thomson]" <Adam.Thomson.Opensource@...semi.com>
CC:	Liam Girdwood <lgirdwood@...il.com>,
	Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.com>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	"alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Support Opensource" <Support.Opensource@...semi.com>
Subject: RE: [PATCH 2/2] ASoC: codecs: Add da7218 codec driver

On November 6, 2015 11:22, Mark Brown wrote:

> > > > +static int da7218_mic_lvl_det_sw_put(struct snd_kcontrol *kcontrol,
> > > > +				     struct snd_ctl_elem_value *ucontrol)
> > > > +{
> 
> > > Why is this a user visible control?
> 
> > I can envisage in a system you may want to choose which capture channels can
> > trigger level detection (if any), and this may change depending on the use-case
> > at the time, so having it as a control makes sense to me.
> 
> What is a "capture channel" here?

Input filters 1L/R and 2L/R, which are fed from either Mic1(ADC1) or DMic1L/R
and Mic2(ADC2) or DMic2L/R.