linux-kernel - Re: [PATCH v3 1/3] ASoC: rockchip: i2s: add 8 channels capture support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151106120020.GH18409@sirena.org.uk>
Date:	Fri, 6 Nov 2015 12:00:20 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Sugar Zhang <sugar.zhang@...k-chips.com>
Cc:	lgirdwood@...il.com, perex@...ex.cz, tiwai@...e.com,
	heiko@...ech.de, alsa-devel@...a-project.org,
	linux-arm-kernel@...ts.infradead.org,
	linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/3] ASoC: rockchip: i2s: add 8 channels capture
 support

On Fri, Nov 06, 2015 at 09:38:09AM +0800, Sugar Zhang wrote:

> +	/* refine capture channels */
> +	if (!of_property_read_u32(node, "rockchip,capture-channels", &val)) {
> +		if (val >= 2 && val <= 8)
> +			rockchip_i2s_dai.capture.channels_max = val;
> +		else
> +			rockchip_i2s_dai.capture.channels_max = 2;
> +	}

You should make a copy of the rockchip_i2s_dai struct in your driver
data and modify that rather than modifying the original - what happens
if sommeone makes a SoC with two I2S DAIs, one with many channels and
another with only two?  Samsung SoCs often have an arrangement like that
for exmaple.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)