linux-kernel - Re: [PATCH v10 1/1] pwm: core: Set enable state properly on failed call to enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 6 Nov 2015 14:46:39 +0100
From:	Thierry Reding <thierry.reding@...il.com>
To:	Jonathan Richardson <jonathar@...adcom.com>
Cc:	Tim Kryger <tim.kryger@...il.com>,
	Dmitry Torokhov <dtor@...gle.com>,
	Anatol Pomazau <anatol@...gle.com>,
	Arun Ramamurthy <arun.ramamurthy@...adcom.com>,
	Scott Branden <sbranden@...adcom.com>,
	bcm-kernel-feedback-list <bcm-kernel-feedback-list@...adcom.com>,
	linux-kernel@...r.kernel.org, linux-pwm@...r.kernel.org
Subject: Re: [PATCH v10 1/1] pwm: core: Set enable state properly on failed
 call to enable

On Fri, Oct 16, 2015 at 05:40:58PM -0700, Jonathan Richardson wrote:
> The pwm_enable function didn't clear the enabled bit if a call to a
> clients enable function returned an error. The result was that the state
> of the pwm core was wrong. Clearing the bit when enable returns an error
> ensures the state is properly set.
> 
> Tested-by: Jonathan Richardson <jonathar@...adcom.com>
> Reviewed-by: Dmitry Torokhov <dmitry.torokhov@...il.com>
> Signed-off-by: Jonathan Richardson <jonathar@...adcom.com>
> ---
>  drivers/pwm/core.c  | 33 ++++++++++++++++++++++++++-------
>  include/linux/pwm.h |  2 ++
>  2 files changed, 28 insertions(+), 7 deletions(-)

Applied, thanks.

Thierry

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)