linux-kernel - RE: [PATCH v2] acpi: Use kstrtoul() instead of strtoul()/simple

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <94F2FBAB4432B54E8AACC7DFDE6C92E37D991668@ORSMSX112.amr.corp.intel.com>
Date:	Fri, 6 Nov 2015 16:21:41 +0000
From:	"Moore, Robert" <robert.moore@...el.com>
To:	Guenter Roeck <linux@...ck-us.net>, Pavel Machek <pavel@....cz>
CC:	"rjw@...ysocki.net" <rjw@...ysocki.net>,
	"lenb@...nel.org" <lenb@...nel.org>,
	"Zheng, Lv" <lv.zheng@...el.com>,
	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devel@...ica.org" <devel@...ica.org>,
	"Wysocki, Rafael J" <rafael.j.wysocki@...el.com>
Subject: RE: [PATCH v2] acpi: Use kstrtoul() instead of
 strtoul()/simple_strtoul()


> Subject: Re: [PATCH v2] acpi: Use kstrtoul() instead of
> strtoul()/simple_strtoul()

So, this would fix the issue(s) (in aclinux.h):

#define strtoul                     kstrtoul



strtoul is used frequently in with the ACPICA in-kernel AML Debugger:

dbcmds.c(188):        Address = strtoul (InString, NULL, 16);
dbcmds.c(266):    SleepState = (UINT8) strtoul (ObjectArg, NULL, 0);
dbcmds.c(1283):    GpeNumber = strtoul (GpeArg, NULL, 0);
dbcmds.c(1291):        BlockNumber = strtoul (BlockArg, NULL, 0);
dbdisply.c(213):    Address = strtoul (Target, NULL, 16);
dbdisply.c(749):    Handle = ACPI_TO_POINTER (strtoul (ObjectArg, NULL, 16));
dbexec.c(769):    NumThreads = strtoul (NumThreadsArg, NULL, 0);
dbexec.c(770):    NumLoops = strtoul (NumLoopsArg, NULL, 0);
dbhistry.c(292):        CmdNum = strtoul (CommandNumArg, NULL, 0);
dbinput.c(1018):                strtoul (AcpiGbl_DbArgs[1], NULL, 16);
dbinput.c(1026):            AcpiGbl_DbDebugLevel = strtoul (AcpiGbl_DbArgs[1], NULL, 16);
dbinput.c(1060):        Temp = strtoul (AcpiGbl_DbArgs[2], NULL, 0);
dbmethod.c(162):    Address = strtoul (Location, NULL, 16);
dbmethod.c(249):    Value = strtoul (ValueArg, NULL, 16);
dbmethod.c(271):    Index = strtoul (IndexArg, NULL, 16);
dbmethod.c(381):        NumStatements = strtoul (Statements, NULL, 0);
dbnames.c(334):            MaxDepth = strtoul (DepthArg, NULL, 0);
dbnames.c(405):    OwnerId = (ACPI_OWNER_ID) strtoul (OwnerArg, NULL, 0);
dbnames.c(411):        MaxDepth = strtoul (DepthArg, NULL, 0);
dbnames.c(990):    Address = strtoul (ObjectArg, NULL, 16);
dbtest.c(1046):        Info.MaxCount = strtoul (CountArg, NULL, 0);






> -----Original Message-----
> From: Guenter Roeck [mailto:linux@...ck-us.net]
> Sent: Sunday, August 02, 2015 1:19 AM
> To: Pavel Machek
> Cc: rjw@...ysocki.net; lenb@...nel.org; Moore, Robert; Zheng, Lv; linux-
> acpi@...r.kernel.org; linux-kernel@...r.kernel.org; devel@...ica.org
> Subject: Re: [PATCH v2] acpi: Use kstrtoul() instead of
> strtoul()/simple_strtoul()
> 
> On 08/02/2015 12:16 AM, Pavel Machek wrote:
> > On Mon 2015-07-27 17:32:22, Guenter Roeck wrote:
> >> simple_strtoul() is deprecated; replace with kstrtoul() and
> kstrtouint().
> >> Return an error if the value passed to the sysfs attribute is not a
> >> number.
> >>
> >> Drop the definition of strtoul() since it is no longer needed.
> >>
> >> Signed-off-by: Guenter Roeck <linux@...ck-us.net>
> >> ---
> >> v2: An additional use of strtoul() was introduced with commit 4fa4616e.
> >>      Replace it as well.
> >>
> >>   drivers/acpi/acpica/evgpeinit.c | 5 +++--
> >>   drivers/acpi/sysfs.c            | 8 ++++++--
> >>   include/acpi/platform/aclinux.h | 1 -
> >>   3 files changed, 9 insertions(+), 5 deletions(-)
> >>
> >> diff --git a/drivers/acpi/acpica/evgpeinit.c
> >> b/drivers/acpi/acpica/evgpeinit.c index ea4c0d3fca2d..aa1e8c1f2d4a
> >> 100644
> >> --- a/drivers/acpi/acpica/evgpeinit.c
> >> +++ b/drivers/acpi/acpica/evgpeinit.c
> >> @@ -326,6 +326,7 @@ acpi_ev_match_gpe_method(acpi_handle obj_handle,
> >>   	u32 gpe_number;
> >>   	char name[ACPI_NAME_SIZE + 1];
> >>   	u8 type;
> >> +	int err;
> >>
> >>   	ACPI_FUNCTION_TRACE(ev_match_gpe_method);
> >>
> >> @@ -377,8 +378,8 @@ acpi_ev_match_gpe_method(acpi_handle obj_handle,
> >>
> >>   	/* 4) The last two characters of the name are the hex GPE Number
> >> */
> >>
> >> -	gpe_number = strtoul(&name[2], NULL, 16);
> >> -	if (gpe_number == ACPI_UINT32_MAX) {
> >> +	er = kstrtouint(&name[2], 16, &gpe_number);
> >> +	if (err < 0 || gpe_number == ACPI_UINT32_MAX) {
> >
> > Are you sure you compile-tested this?
> >
> 
> I was, but maybe not ;-). Since the patch was rejected it does not really
> matter.
> 
> Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/