linux-kernel - Re: [PATCH] bcache: Really show state of work pending bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1511061507140.23146@pobox.suse.cz>
Date:	Fri, 6 Nov 2015 20:55:17 +0100 (CET)
From:	Jiri Kosina <jikos@...nel.org>
To:	Petr Mladek <pmladek@...e.com>
cc:	Kent Overstreet <kent.overstreet@...il.com>,
	Tejun Heo <tj@...nel.org>, Neil Brown <neilb@...e.com>,
	linux-bcache@...r.kernel.org, linux-raid@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] bcache: Really show state of work pending bit

On Mon, 5 Oct 2015, Petr Mladek wrote:

> WORK_STRUCT_PENDING is a mask for testing the pending bit.
> test_bit() expects the number of the bit and we need to
> use WORK_STRUCT_PENDING_BIT there.
> 
> Also work_data_bits() is defined in workqueues.h now.
> 
> I have noticed this just by chance when looking how
> WORK_STRUCT_PENDING_BIT is used. The change is compile
> tested.
> 
> Signed-off-by: Petr Mladek <pmladek@...e.com>
> ---
>  drivers/md/bcache/closure.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/md/bcache/closure.c b/drivers/md/bcache/closure.c
> index 7a228de95fd7..9eaf1d6e8302 100644
> --- a/drivers/md/bcache/closure.c
> +++ b/drivers/md/bcache/closure.c
> @@ -167,8 +167,6 @@ EXPORT_SYMBOL(closure_debug_destroy);
>  
>  static struct dentry *debug;
>  
> -#define work_data_bits(work) ((unsigned long *)(&(work)->data))
> -
>  static int debug_seq_show(struct seq_file *f, void *data)
>  {
>  	struct closure *cl;
> @@ -182,7 +180,7 @@ static int debug_seq_show(struct seq_file *f, void *data)
>  			   r & CLOSURE_REMAINING_MASK);
>  
>  		seq_printf(f, "%s%s%s%s\n",
> -			   test_bit(WORK_STRUCT_PENDING,
> +			   test_bit(WORK_STRUCT_PENDING_BIT,

I don't see this in linux-next as of today, so I am picking it up for 4.4.

-- 
Jiri Kosina 
SUSE Labs

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/