linux-kernel - Re: [PATCH] raid5-cache: add crc32c Kconfig dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87si4jak7k.fsf@notabene.neil.brown.name>
Date:	Fri, 06 Nov 2015 14:19:11 +1100
From:	Neil Brown <neilb@...e.com>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Shaohua Li <shli@...com>,
	Bart Van Assche <bart.vanassche@...disk.com>,
	linux-raid@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] raid5-cache: add crc32c Kconfig dependency

On Wed, Nov 04 2015, Arnd Bergmann wrote:

> The recent change of the raid5-cache code to use crc32c instead
> of crc32 causes link errors when CONFIG_LIBCRC32C is disabled:
>
> drivers/built-in.o: In function crc32c'
> core.c:(.text+0x1c6060): undefined reference to `crc32c'
>
> This adds an explicit 'select' statement like all other users
> of this function do.
>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Fixes: 5cb2fbd6ea0d ("raid5-cache: use crc32c checksum")
>
> diff --git a/drivers/md/Kconfig b/drivers/md/Kconfig
> index 3e01e6fb3424..7913fdcfc849 100644
> --- a/drivers/md/Kconfig
> +++ b/drivers/md/Kconfig
> @@ -123,6 +123,7 @@ config MD_RAID456
>  	tristate "RAID-4/RAID-5/RAID-6 mode"
>  	depends on BLK_DEV_MD
>  	select RAID6_PQ
> +	select LIBCRC32C
>  	select ASYNC_MEMCPY
>  	select ASYNC_XOR
>  	select ASYNC_PQ

Applied, thanks,

NeilBrown

Download attachment "signature.asc" of type "application/pgp-signature" (819 bytes)