linux-kernel - Re: [PATCH] Staging: wilc1000: Declare *wilc in init_wilc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151106221624.GE18797@mwanda>
Date:	Sat, 7 Nov 2015 01:16:24 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	punit vara <punitvara@...il.com>
Cc:	Greg KH <gregkh@...uxfoundation.org>, devel@...verdev.osuosl.org,
	linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: wilc1000: Declare *wilc in init_wilc_driver to
 fix build error

Oh...  Sorry.  I got your email confused with someone else.

> > diff --git a/drivers/staging/wilc1000/linux_wlan.c b/drivers/staging/wilc1000/linux_wlan.c
> > index 2a5b36f..0805050 100644
> > --- a/drivers/staging/wilc1000/linux_wlan.c
> > +++ b/drivers/staging/wilc1000/linux_wlan.c
> > @@ -1780,6 +1780,7 @@ int wilc_netdev_init(struct wilc **wilc)
> >  /*The 1st function called after module inserted*/
> >  static int __init init_wilc_driver(void)
> >  {
> > +       struct wilc *wilc;
> >  #ifdef WILC_SPI
> >         struct wilc *wilc;
> >  #endif


The problem is that now if WILC_SPI is defined it's declared twice so
this patch is definitely wrong.  I haven't looked at it further than
that, sorry.

CC the atmel people with these patches.  Use ./scripts/get_maintainer.pl
to find the right maintainers.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/