linux-kernel - Re: [PATCH] of: Provide static inline function for of_translate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3724502.6sHTjrfvab@wuerfel>
Date:	Sat, 07 Nov 2015 10:02:20 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	Guenter Roeck <linux@...ck-us.net>
Cc:	Rob Herring <robh+dt@...nel.org>,
	Frank Rowand <frowand.list@...il.com>,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] of: Provide static inline function for of_translate_address if needed

On Friday 06 November 2015 19:28:22 Guenter Roeck wrote:
> If OF_ADDRESS is not configured, builds can fail with errors such as
> 
> drivers/net/ethernet/hisilicon/hns_mdio.c:
> 	In function 'hns_mdio_bus_name':
> drivers/net/ethernet/hisilicon/hns_mdio.c:411:3:
> 	error: implicit declaration of function 'of_translate_address'
> 
> as currently seen when building sparc:allmodconfig.
> 
> Introduce a static inline function if OF_ADDRESS is not configured to fix
> the build failure. Return OF_BAD_ADDR in this case. For this to work, the
> definition of OF_BAD_ADDR has to be moved outside CONFIG_OF conditional
> code.
> 
> Fixes: 876133d3161d ("net: hisilicon: add OF dependency")
> Cc: Arnd Bergmann <arnd@...db.de>
> Signed-off-by: Guenter Roeck <linux@...ck-us.net>

Reviewed-by: Arnd Bergmann <arnd@...db.de>

Thanks for the fix.

Rob/Frank, any chance we get this into -rc1 through your tree?

The background is that a bugfix I did for a network driver started
causing the build error on sparc allmodconfig, and it would be nice
to have 4.4-rc1 build fine without having to back out my fix.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/