linux-kernel - Re: [PATCH 00/13] High performance balancing logic for big.LITTLE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151107095237.GS3604@twins.programming.kicks-ass.net>
Date:	Sat, 7 Nov 2015 10:52:37 +0100
From:	Peter Zijlstra <peterz@...radead.org>
To:	Arseniy Krasnov <a.krasnov@...sung.com>
Cc:	linux@....linux.org.uk, mingo@...hat.com, v.tyrtov@...sung.com,
	s.rogachev@...sung.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 00/13] High performance balancing logic for big.LITTLE

No, no, no, no.

This is horrible and exactly what I've been telling people I do not want
to see.

This is very arch specific scheduler code, and very badly done. It
doesn't even call the groups big and little, it goes so far as to put a7
and a15 in sched domain member names.

It doesn't get topology information from device tree but from hard coded
CONFIG strings.

It introduces a swap_task function while we already have one.

It doesn't integrate with any of the other bits that make up and
influence energy consumption such as cpuidle and cpufreq (very minor one
way).

It doesn't mention the existing energy-aware-scheduling effort, nor how
that approach cannot be made to work for this.

It has a completely broken SoB chain.

It introduces new metrics (like druntime) without first defining them;
and in general very poor Changelogs.

In general, this makes me very sad. Please start by participating in the
existing discussion.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/