linux-kernel - Re: [PATCH 1/4] x86/entry/64: Fix irqflag tracing wrt context tracking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.11.1511071058550.4032@nanos>
Date:	Sat, 7 Nov 2015 10:59:16 +0100 (CET)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Andy Lutomirski <luto@...nel.org>
cc:	x86@...nel.org, linux-kernel@...r.kernel.org,
	Brian Gerst <brgerst@...il.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Borislav Petkov <bp@...en8.de>,
	Frédéric Weisbecker <fweisbec@...il.com>,
	Peter Zijlstra <peterz@...radead.org>
Subject: Re: [PATCH 1/4] x86/entry/64: Fix irqflag tracing wrt context
 tracking

On Fri, 6 Nov 2015, Andy Lutomirski wrote:
> Paolo pointed out that enter_from_user_mode could be called while
> irqflags were traced as though IRQs were on.
> 
> In principle, this could confuse lockdep.  It doesn't cause any
> problems that I've seen in any configuration, but if I build with
> CONFIG_DEBUG_LOCKDEP=y, enable a nohz_full CPU, and add code like:
> 
> 	if (irqs_disabled()) {
> 		spin_lock(&something);
> 		spin_unlock(&something);
> 	}
> 
> to the top of enter_from_user_mode, then lockdep will complain
> without this fix.  It seems that lockdep's irqflags sanity checks
> are too weak to detect this bug without forcing the issue.
> 
> This patch adds one byte to normal kernels, and it's IMO a bit ugly.
> I haven't spotted a better way to do this yet, though.  The issue is
> that we can't do TRACE_IRQS_OFF until after SWAPGS (if needed), but
> we're also supposed to do it before calling C code.
> 
> An alternative approach would be to call trace_hardirqs_off in
> enter_from_user_mode.  That would be less code and would not bloat
> normal kernels at all, but it would be harder to see how the code
> worked.
> 
> Signed-off-by: Andy Lutomirski <luto@...nel.org>

Reviewed-by: Thomas Gleixner <tglx@...utronix.de>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/