[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20151107124230.GF3378@x1>
Date: Sat, 7 Nov 2015 12:42:30 +0000
From: Lee Jones <lee.jones@...aro.org>
To: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [GIT PULL] MFD for v4.4
On Fri, 06 Nov 2015, Linus Torvalds wrote:
> On Fri, Nov 6, 2015 at 12:04 AM, Lee Jones <lee.jones@...aro.org> wrote:
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git tags/mfd-for-linus-4.4
>
> Ugh.
>
> Maintainers, *please* check new warnings you introduce. We don't have
> that many compiler warnings in the kernel, you shouldn't be
> introducing new ones and not notice.
>
> This pull request introduces this silly new warning:
>
> drivers/mfd/rtsx_pcr.c: In function ‘rtsx_pci_set_pull_ctl’:
> drivers/mfd/rtsx_pcr.c:565:6: warning: unused variable ‘err’
> [-Wunused-variable]
> int err;
> ^
>
> due to commit b158b69a3765 ("mfd: rtsx: Simplify function return
> logic") that removes the actual use of the variable, but not the
> variable itself.
I thought these were cleaned up. Apologies for that.
Do you want me to submit a fix, or did you already rectify?
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists