linux-kernel - Re: [PATCH 08/10] tpm: seal/unseal for TPM 2.0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151107185803.GA3375@newt.localdomain>
Date:	Sat, 7 Nov 2015 10:58:03 -0800
From:	Jeremiah Mahler <jmmahler@...il.com>
To:	Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
Cc:	tpmdd-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org,
	peterhuewe@....de, gregkh@...uxfoundation.org,
	jgunthorpe@...idianresearch.com, dhowells@...hat.com,
	artem.bityutskiy@...ux.intel.com,
	Marcel Selhorst <tpmdd@...horst.net>,
	David Safford <safford@...ibm.com>,
	Mimi Zohar <zohar@...ux.vnet.ibm.com>,
	"open list:KEYS-TRUSTED" <linux-security-module@...r.kernel.org>,
	"open list:KEYS-TRUSTED" <keyrings@...r.kernel.org>
Subject: Re: [PATCH 08/10] tpm: seal/unseal for TPM 2.0

Jarkko,

On Fri, Oct 16, 2015 at 09:40:27PM +0300, Jarkko Sakkinen wrote:
> Added tpm_trusted_seal() and tpm_trusted_unseal() API for sealing
> trusted keys.
> 
> This patch implements basic sealing and unsealing functionality for
> TPM 2.0:
> 
> * Seal with a parent key using a 20 byte auth value.
> * Unseal with a parent key using a 20 byte auth value.
> 
> Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
> ---
>  drivers/char/tpm/tpm-interface.c |  76 ++++++++++++
>  drivers/char/tpm/tpm.h           |  15 ++-
>  drivers/char/tpm/tpm2-cmd.c      | 250 ++++++++++++++++++++++++++++++++++++++-
>  include/keys/trusted-type.h      |   2 +-
>  include/linux/tpm.h              |  26 ++++
>  5 files changed, 366 insertions(+), 3 deletions(-)
> 

This patch adds a lot of code but doesn't use any of it until later
patches.  This can make using 'git bisect' more difficult because it
will point to the wrong patches.  If this were my patch series I would
combine this patch with the later ones that actually start using the
code.

[...]

-- 
- Jeremiah Mahler
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/