linux-kernel - Re: [PATCH 1/3] Staging: lustre: module: Replace function calls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <D12D10D3-A25C-41E3-A1EC-D69982D1BFBF@intel.com>
Date:	Sat, 7 Nov 2015 19:27:16 +0000
From:	"Dilger, Andreas" <andreas.dilger@...el.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
CC:	"Simmons, James A." <simmonsja@...l.gov>,
	Shivani Bhardwaj <shivanib134@...il.com>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"Drokin, Oleg" <oleg.drokin@...el.com>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3] Staging: lustre: module: Replace function calls

On Nov 7, 2015, at 04:15, Dan Carpenter <dan.carpenter@...cle.com> wrote:
> 
> On Fri, Nov 06, 2015 at 10:04:41PM +0000, Simmons, James A. wrote:
>>> From: devel [mailto:driverdev-devel-bounces@...uxdriverproject.org] On Behalf Of Shivani Bhardwaj
>>> Sent: Friday, November 06, 2015 12:18 PM
>>> To: gregkh@...uxfoundation.org
>>> Cc: oleg.drokin@...el.com; devel@...verdev.osuosl.org; andreas.dilger@...el.com; linux-kernel@...r.kernel.org
>>> Subject: [PATCH 1/3] Staging: lustre: module: Replace function calls
>>> 
>>> Replace the calls of function cfs_trace_free_string_buffer() with
>>> kfree() as the former function is not required.
>>> 
>>> Signed-off-by: Shivani Bhardwaj <shivanib134@...il.com>
>>> ---
>>> drivers/staging/lustre/lustre/libcfs/module.c | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>> 
>> Acked-by: James Simmons <jsimmons@...radead.org>
>> 
>> diff --git a/drivers/staging/lustre/lustre/libcfs/module.c b/drivers/staging/lustre/lustre/libcfs/module.c
>> index 50e8fd2..516a9e7 100644
>> --- a/drivers/staging/lustre/lustre/libcfs/module.c
>> +++ b/drivers/staging/lustre/lustre/libcfs/module.c
>> @@ -392,7 +392,7 @@ static int __proc_dobitmasks(void *data, int write,
>>    } else {
> 
> Why do your acks include the original diff without the "> " prefix?  How
> are you even managing that trick?

I was wondering the same, though it does look nicer. 

Cheers, Andreas--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/