linux-kernel - Re: next-20151101 - depmod issues with Lustre modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 7 Nov 2015 14:30:44 -0800
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Dmitry Safonov <0x7f454c46@...il.com>,
	James Simmons <jsimmons@...radead.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Stephen Rothwell <sfr@...b.auug.org.au>
Cc:	Valdis Kletnieks <Valdis.Kletnieks@...edu>,
	Oleg Drokin <oleg.drokin@...el.com>,
	Andreas Dilger <andreas.dilger@...el.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	lustre-devel@...ts.lustre.org
Subject: Re: next-20151101 - depmod issues with Lustre modules

On Sat, Nov 7, 2015 at 12:37 PM, Dmitry Safonov <0x7f454c46@...il.com> wrote:
> Reproduced on mainline v4.3-9038-g27eb427bdc0960 with
> Arch Linux default config (attached):
>
> depmod: ERROR: Found 2 modules in dependency cycles!
> depmod: ERROR: Cycle detected: lnet -> libcfs -> lnet
> make: *** [_modinst_post] Error 1

The reason seems to be that

 - lnet.ko provides the following functions needed by libcfs.ko:

    libcfs_next_nidstring
    libcfs_nid2str_r

 - libcfs.ko provides the following functions needed by lnet.ko:

    libcfs_debug
    libcfs_debug_msg
    libcfs_deregister_ioctl
    libcfs_register_ioctl
    libcfs_subsystem_debug
    lustre_insert_debugfs

but I may have messed up something.

Anyway, the problem seems to be that - insanely - lnet.ko provides
those libcfs nid handling functions. They should be in libcfs, as far
as I can tell, just judging by the name. Also judging by the use.

The cause seems to be commit 47ca6ec2673e ("staging: lustre: move
nidstring handling to LNet layer") by James Simmons.

I do wonder if linux-next could perhaps do some modprobe testing too?

                      Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/