linux-kernel - Re: [PATCH] tty: audit: Fix audit source

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201511082100.lAxO7dtn%fengguang.wu@intel.com>
Date:	Sun, 8 Nov 2015 21:01:46 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Peter Hurley <peter@...leysoftware.com>
Cc:	kbuild-all@...org, Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jiri Slaby <jslaby@...e.cz>, linux-kernel@...r.kernel.org,
	Peter Hurley <peter@...leysoftware.com>,
	Laura Abbott <labbott@...oraproject.org>,
	Miloslav Trmač <mitr@...hat.com>,
	stable@...r.kernel.org
Subject: Re: [PATCH] tty: audit: Fix audit source

Hi Peter,

[auto build test WARNING on: v4.3-rc7]
[also build test WARNING on: next-20151106]

url:    https://github.com/0day-ci/linux/commits/Peter-Hurley/tty-audit-Fix-audit-source/20151108-205330
config: x86_64-randconfig-x019-201545 (attached as .config)
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   drivers/tty/n_tty.c: In function 'tty_copy_to_user':
>> drivers/tty/n_tty.c:172:26: warning: passing argument 2 of 'tty_audit_add_data' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
     tty_audit_add_data(tty, from, n, ldata->icanon);
                             ^
   In file included from drivers/tty/n_tty.c:40:0:
   include/linux/tty.h:616:20: note: expected 'unsigned char *' but argument is of type 'const void *'
    static inline void tty_audit_add_data(struct tty_struct *tty,
                       ^

vim +172 drivers/tty/n_tty.c

   156	static inline int tty_put_user(struct tty_struct *tty, unsigned char x,
   157				       unsigned char __user *ptr)
   158	{
   159		struct n_tty_data *ldata = tty->disc_data;
   160	
   161		tty_audit_add_data(tty, &x, 1, ldata->icanon);
   162		return put_user(x, ptr);
   163	}
   164	
   165	static inline int tty_copy_to_user(struct tty_struct *tty,
   166						void __user *to,
   167						const void *from,
   168						unsigned long n)
   169	{
   170		struct n_tty_data *ldata = tty->disc_data;
   171	
 > 172		tty_audit_add_data(tty, from, n, ldata->icanon);
   173		return copy_to_user(to, from, n);
   174	}
   175	
   176	/**
   177	 *	n_tty_kick_worker - start input worker (if required)
   178	 *	@tty: terminal
   179	 *
   180	 *	Re-schedules the flip buffer work if it may have stopped

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (25176 bytes)