lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 9 Nov 2015 10:02:27 +0800 From: Baolin Wang <baolin.wang@...aro.org> To: Greg KH <gregkh@...uxfoundation.org> Cc: Felipe Balbi <balbi@...com>, sre@...nel.org, Dmitry Eremin-Solenikov <dbaryshkov@...il.com>, David Woodhouse <dwmw2@...radead.org>, Mark Brown <broonie@...nel.org>, LKML <linux-kernel@...r.kernel.org>, Peter Chen <peter.chen@...escale.com>, Alan Stern <stern@...land.harvard.edu>, r.baldyga@...sung.com, yoshihiro.shimoda.uh@...esas.com, linux-usb@...r.kernel.org, device-mainlining@...ts.linuxfoundation.org, sameo@...ux.intel.com, Lee Jones <lee.jones@...aro.org>, ckeepax@...nsource.wolfsonmicro.com, patches@...nsource.wolfsonmicro.com, linux-pm@...r.kernel.org Subject: Re: [PATCH v5 1/5] gadget: Introduce the notifier functions On 7 November 2015 at 00:56, Greg KH <gregkh@...uxfoundation.org> wrote: > On Fri, Nov 06, 2015 at 07:35:10PM +0800, Baolin Wang wrote: >> #ifdef CONFIG_HAS_DMA >> diff --git a/include/linux/usb/gadget.h b/include/linux/usb/gadget.h >> index c14a69b..755e8bc 100644 >> --- a/include/linux/usb/gadget.h >> +++ b/include/linux/usb/gadget.h >> @@ -609,6 +609,8 @@ struct usb_gadget { >> unsigned out_epnum; >> unsigned in_epnum; >> struct usb_otg_caps *otg_caps; >> + struct raw_notifier_head nh; >> + struct mutex lock; > > You have to document what this lock protects. OK. > > >> >> unsigned sg_supported:1; >> unsigned is_otg:1; >> @@ -1183,6 +1185,22 @@ extern void usb_gadget_unmap_request(struct usb_gadget *gadget, >> >> /*-------------------------------------------------------------------------*/ >> >> +/** >> + * Register a notifiee to get notified by any attach status changes from >> + * the usb gadget >> + */ > > kerneldoc does not belong in a .h file. > I'll remove the comments. > And the kbuild system found lots of problems with this series, please > fix those at the very least :( I'm sorry for that, I'll check the patches again. Thanks for your comments. > > thanks, > > greg k-h -- Baolin.wang Best Regards -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists