lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 8 Nov 2015 21:17:20 -0500 From: Sinan Kaya <okaya@...eaurora.org> To: Timur Tabi <timur@...eaurora.org>, dmaengine@...r.kernel.org, cov@...eaurora.org, jcm@...hat.com Cc: agross@...eaurora.org, linux-arm-msm@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, Rob Herring <robh+dt@...nel.org>, Pawel Moll <pawel.moll@....com>, Mark Rutland <mark.rutland@....com>, Ian Campbell <ijc+devicetree@...lion.org.uk>, Kumar Gala <galak@...eaurora.org>, Vinod Koul <vinod.koul@...el.com>, Dan Williams <dan.j.williams@...el.com>, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH V3 2/4] dma: add Qualcomm Technologies HIDMA management driver On 11/8/2015 12:08 AM, Timur Tabi wrote: On 11/8/2015 12:08 AM, Timur Tabi wrote: > Sinan Kaya wrote: >> + val = val & ~(MAX_BUS_REQ_LEN_MASK << MAX_BUS_WR_REQ_BIT_POS); >> + val = val | (mgmtdev->max_write_request << MAX_BUS_WR_REQ_BIT_POS); >> + val = val & ~(MAX_BUS_REQ_LEN_MASK); >> + val = val | (mgmtdev->max_read_request); > > val &= ~MAX_BUS_REQ_LEN_MASK << MAX_BUS_WR_REQ_BIT_POS; > val |= mgmtdev->max_write_request << MAX_BUS_WR_REQ_BIT_POS; > val &= ~MAX_BUS_REQ_LEN_MASK; > val |= mgmtdev->max_read_request; > >> +static const struct of_device_id hidma_mgmt_match[] = { >> + { .compatible = "qcom,hidma-mgmt", }, >> + { .compatible = "qcom,hidma-mgmt-1.0", }, >> + { .compatible = "qcom,hidma-mgmt-1.1", }, >> + {}, >> +}; > > I thought Rob said that he did NOT want to use version numbers in > compatible strings. And what's the difference between these three > versions anyway? > This was already discussed here. https://lkml.org/lkml/2015/11/2/689 The agreement was to use compatible = "qcom,hidma-mgmt-1.1", "qcom,hidma-mgmt-1.0", "qcom,hidma-mgmt"; I'll be adding code for v1.1 specifically in the future. -- Sinan Kaya Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists