linux-kernel - Re: [PATCH 03/26] Input: synaptics-rmi4 - explicitly request polling when needed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdZTquLDC4r1=9-qkfjLEidu8ZS0iqpwHcZfCu+BKuSTVg@mail.gmail.com>
Date:	Mon, 9 Nov 2015 13:58:08 +0100
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Andrew Duggan <aduggan@...aptics.com>
Cc:	Linux Input <linux-input@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Benjamin Tissoires <benjamin.tissoires@...hat.com>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Benjamin Tissoires <benjamin.tissoires@...il.com>,
	Christopher Heiny <cheiny@...aptics.com>,
	Stephen Chandler Paul <cpaul@...hat.com>
Subject: Re: [PATCH 03/26] Input: synaptics-rmi4 - explicitly request polling
 when needed

On Fri, Nov 6, 2015 at 12:37 AM, Andrew Duggan <aduggan@...aptics.com> wrote:

> From: Benjamin Tissoires <benjamin.tissoires@...hat.com>
>
> Host Notify does not work with neither IRQ nor polling. Allow a RMI4 driver
> to request or not polling depending on the attn_gpio.
>
> When neither the internal IRQ or polling systems are used, the
> transport driver can call rmi_process_interrupt_requests() to
> trigger a process of the alert.
>
> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@...hat.com>
> Tested-by: Andrew Duggan <aduggan@...aptics.com>

(...)
> +       } else if (pdata->attn_gpio == RMI_POLLING) {
(...)
> +#define RMI_POLLING    -1

Aeuck ... this thing should be rewritten to use GPIO descriptors
instead of this old number-based stuff.

I'll go in and see if I can take a stab at it.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/