linux-kernel - Re: [PATCH] Input: parkbd - Drop bogus __init from parkbd_allocate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 9 Nov 2015 18:35:27 +0530
From:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Input: parkbd - Drop bogus __init from
 parkbd_allocate_serio()

On Sat, Nov 07, 2015 at 04:53:23PM +0100, Geert Uytterhoeven wrote:
> WARNING: vmlinux.o(.text+0x1056606): Section mismatch in reference from the function parkbd_attach() to the function .init.text:parkbd_allocate_serio()
> The function parkbd_attach() references
> the function __init parkbd_allocate_serio().
> This is often because parkbd_attach lacks a __init
> annotation or the annotation of parkbd_allocate_serio is wrong.
> 
> Commit 33ca8ab97cbb676d ("Input: parkbd - use parallel port device
> model") dropped the __init attribute from the sole caller of
> parkbd_allocate_serio(), but forgot to remove it from
> parkbd_allocate_serio() itself.
> 
> Fixes: 33ca8ab97cbb676d ("Input: parkbd - use parallel port device model")
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>

I don't see this with allmodconfig on i386 or on x86_64. How did you get
this warning? But anyway, looking at the code, i did miss attribute.

Acked-by: Sudip Mukherjee <sudipm.mukherjee@...il.com>

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/