linux-kernel - Re: [PATCH v5 0/5] usb/gadget: independent registration of gadgets and gadget drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151109000755.GV6114@lukather>
Date:	Sun, 8 Nov 2015 16:07:55 -0800
From:	Maxime Ripard <maxime.ripard@...e-electrons.com>
To:	Ruslan Bilovol <ruslan.bilovol@...il.com>
Cc:	"Balbi, Felipe" <balbi@...com>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Krzysztof Opasiak <k.opasiak@...sung.com>,
	Alan Stern <stern@...land.harvard.edu>,
	Peter Chen <peter.chen@...escale.com>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	Andrzej Pietrasiewicz <andrzej.p@...sung.com>
Subject: Re: [PATCH v5 0/5] usb/gadget: independent registration of gadgets
 and gadget drivers

Hi Ruslan,

On Mon, Nov 02, 2015 at 06:44:00PM +0200, Ruslan Bilovol wrote:
> >> This patchset adds independent registration of gadgets
> >> and gadget drivers to udc-core. This is very useful for
> >> built-in modules into kernel case since it's possible
> >> situation that gadget driver is probing at a time
> >> when no gadgets are registered in udc-core.
> >> In this case instead of silently failing without
> >> of any attempt to recover, with independent registration
> >> of gadgets and gadget drivers there is no matter
> >> in which order gadgets and gadget drivers are
> >> probed/registered.
> >>
> >> This patch has side-effect on gadget drivers that had
> >> __init/__exit attributes on some paths like bind/unbind
> >> and (since bind/unbind may happen at any time) should
> >> not use them now. This is covered by forth patch
> >>
> >
> > Has there been any progress on these patches? They're fixing some real
> > issue that we're seeing, and it seems to both work quite well and not
> > generate a lot of pushback.
> 
> This patch series has stack on review due to different views
> on checking input parameters of externally visible function.
> 
> I see there is no any way to get these patches accepted other
> than skip checking validity of some input parameters as
> was pointed by Alan, although I disagree with it.
> 
> I will post updated patch series later

Great, thanks a lot!

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)