linux-kernel - Re: [PATCH 18/26] Input: synaptics-rmi4: Add SPI transport driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdb2RdLUWv1kykDi-RBA0PVM7QfRkyLB4oRC0CUmW+Wjzg@mail.gmail.com>
Date:	Mon, 9 Nov 2015 14:17:37 +0100
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Andrew Duggan <aduggan@...aptics.com>
Cc:	Linux Input <linux-input@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Benjamin Tissoires <benjamin.tissoires@...il.com>,
	Christopher Heiny <cheiny@...aptics.com>,
	Stephen Chandler Paul <cpaul@...hat.com>
Subject: Re: [PATCH 18/26] Input: synaptics-rmi4: Add SPI transport driver

On Fri, Nov 6, 2015 at 12:41 AM, Andrew Duggan <aduggan@...aptics.com> wrote:

> Add a transport driver for devices using RMI4 over SPI.
>
> Signed-off-by: Andrew Duggan <aduggan@...aptics.com>


>  .../devicetree/bindings/input/rmi4/rmi_spi.txt     |  57 +++

Split off bindings in a separate patch and send to
devicetree@...r.kernel.org

This binding
Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

> +config RMI4_SPI
> +       tristate "RMI4 SPI Support"
> +       depends on RMI4_CORE && SPI
> +       help
> +         Say Y here if you want to support RMI4 devices connected to a SPI
> +         bus.
> +
> +         If unsure, say N.

It never hurts to put Mark Brown on CC for SPI drivers.
The patch looks good to me (TM)
Acked-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/