linux-kernel - Re: [PATCH] iio: adc: mxs-lradc: Prefer using the BIT macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <201511092214.i7Hnv6JY%fengguang.wu@intel.com>
Date:	Mon, 9 Nov 2015 22:40:04 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Nizam Haider <nizamhaider786@...il.com>
Cc:	kbuild-all@...org, gregkh@...uxfoundation.org, marex@...x.de,
	stefan.wahren@...e.com, lars@...afoo.de, hamohammed.sa@...il.com,
	linux-iio@...r.kernel.org, Nizam Haider <nijamh@...c.in>,
	devel@...verdev.osuosl.org,
	Nizam Haider <nizamhaider786@...il.com>,
	linux-kernel@...r.kernel.org, alexandre.belloni@...e-electrons.com,
	pmeerw@...erw.net, knaack.h@....de, ciorneiioana@...il.com,
	jic23@...nel.org
Subject: Re: [PATCH] iio: adc: mxs-lradc: Prefer using the BIT macro

Hi Nizam,

[auto build test WARNING on staging/staging-testing]
[also build test WARNING on v4.3 next-20151109]

url:    https://github.com/0day-ci/linux/commits/Nizam-Haider/iio-adc-mxs-lradc-Prefer-using-the-BIT-macro/20151109-222735
config: sparc64-allyesconfig (attached as .config)
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=sparc64 

All warnings (new ones prefixed by >>):

   drivers/staging/iio/adc/mxs-lradc.c: In function 'mxs_lradc_complete_touch_event':
>> drivers/staging/iio/adc/mxs-lradc.c:325:5: warning: large integer implicitly truncated to unsigned type [-Woverflow]
        (((x) << LRADC_DELAY_TRIGGER_LRADCS_OFFSET) & \
        ^
>> drivers/staging/iio/adc/mxs-lradc.c:734:7: note: in expansion of macro 'LRADC_DELAY_TRIGGER'
          LRADC_DELAY_TRIGGER(1 << TOUCHSCREEN_VCHANNEL1) |
          ^
   drivers/staging/iio/adc/mxs-lradc.c: In function 'mxs_lradc_buffer_preenable':
   drivers/staging/iio/adc/mxs-lradc.c:322:42: warning: large integer implicitly truncated to unsigned type [-Woverflow]
    #define LRADC_DELAY_TRIGGER_LRADCS_MASK  (0xff << 24)
                                             ^
>> drivers/staging/iio/adc/mxs-lradc.c:1308:29: note: in expansion of macro 'LRADC_DELAY_TRIGGER_LRADCS_MASK'
     mxs_lradc_reg_clear(lradc, LRADC_DELAY_TRIGGER_LRADCS_MASK |
                                ^
   drivers/staging/iio/adc/mxs-lradc.c: In function 'mxs_lradc_buffer_postdisable':
   drivers/staging/iio/adc/mxs-lradc.c:322:42: warning: large integer implicitly truncated to unsigned type [-Woverflow]
    #define LRADC_DELAY_TRIGGER_LRADCS_MASK  (0xff << 24)
                                             ^
   drivers/staging/iio/adc/mxs-lradc.c:1327:29: note: in expansion of macro 'LRADC_DELAY_TRIGGER_LRADCS_MASK'
     mxs_lradc_reg_clear(lradc, LRADC_DELAY_TRIGGER_LRADCS_MASK |
                                ^

vim +325 drivers/staging/iio/adc/mxs-lradc.c

06ddd353 Marek Vasut     2013-01-11  309  #define	LRADC_STATUS				0x40
418880f5 Haneen Mohammed 2015-03-26  310  #define	LRADC_STATUS_TOUCH_DETECT_RAW		BIT(0)
06ddd353 Marek Vasut     2013-01-11  311  
bc2c90c9 Marek Vasut     2012-08-12  312  #define	LRADC_CH(n)				(0x50 + (0x10 * (n)))
418880f5 Haneen Mohammed 2015-03-26  313  #define	LRADC_CH_ACCUMULATE			BIT(29)
bc2c90c9 Marek Vasut     2012-08-12  314  #define	LRADC_CH_NUM_SAMPLES_MASK		(0x1f << 24)
bc2c90c9 Marek Vasut     2012-08-12  315  #define	LRADC_CH_NUM_SAMPLES_OFFSET		24
dee05308 Juergen Beisert 2013-09-23  316  #define	LRADC_CH_NUM_SAMPLES(x) \
dee05308 Juergen Beisert 2013-09-23  317  				((x) << LRADC_CH_NUM_SAMPLES_OFFSET)
bc2c90c9 Marek Vasut     2012-08-12  318  #define	LRADC_CH_VALUE_MASK			0x3ffff
bc2c90c9 Marek Vasut     2012-08-12  319  #define	LRADC_CH_VALUE_OFFSET			0
bc2c90c9 Marek Vasut     2012-08-12  320  
bc2c90c9 Marek Vasut     2012-08-12  321  #define	LRADC_DELAY(n)				(0xd0 + (0x10 * (n)))
bc2c90c9 Marek Vasut     2012-08-12  322  #define	LRADC_DELAY_TRIGGER_LRADCS_MASK		(0xff << 24)
bc2c90c9 Marek Vasut     2012-08-12  323  #define	LRADC_DELAY_TRIGGER_LRADCS_OFFSET	24
dee05308 Juergen Beisert 2013-09-23  324  #define	LRADC_DELAY_TRIGGER(x) \
dee05308 Juergen Beisert 2013-09-23 @325  				(((x) << LRADC_DELAY_TRIGGER_LRADCS_OFFSET) & \
dee05308 Juergen Beisert 2013-09-23  326  				LRADC_DELAY_TRIGGER_LRADCS_MASK)
33365872 Nizam Haider    2015-11-09  327  #define	LRADC_DELAY_KICK			BIT(20)
bc2c90c9 Marek Vasut     2012-08-12  328  #define	LRADC_DELAY_TRIGGER_DELAYS_MASK		(0xf << 16)
bc2c90c9 Marek Vasut     2012-08-12  329  #define	LRADC_DELAY_TRIGGER_DELAYS_OFFSET	16
dee05308 Juergen Beisert 2013-09-23  330  #define	LRADC_DELAY_TRIGGER_DELAYS(x) \
dee05308 Juergen Beisert 2013-09-23  331  				(((x) << LRADC_DELAY_TRIGGER_DELAYS_OFFSET) & \
dee05308 Juergen Beisert 2013-09-23  332  				LRADC_DELAY_TRIGGER_DELAYS_MASK)
bc2c90c9 Marek Vasut     2012-08-12  333  #define	LRADC_DELAY_LOOP_COUNT_MASK		(0x1f << 11)

:::::: The code at line 325 was first introduced by commit
:::::: dee05308f6029caed91e1a015cafb1545958ba27 Staging/iio/adc/touchscreen/MXS: add interrupt driven touch detection

:::::: TO: Juergen Beisert <jbe@...gutronix.de>
:::::: CC: Jonathan Cameron <jic23@...nel.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (44395 bytes)