linux-kernel - Re: [PATCH 1/2] selftests/mlock2: Add missing #define _GNU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151109155013.GB28486@akamai.com>
Date:	Mon, 9 Nov 2015 10:50:13 -0500
From:	Eric B Munson <emunson@...mai.com>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	Thierry Reding <treding@...dia.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Shuah Khan <shuahkh@....samsung.com>,
	linux-api@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] selftests/mlock2: Add missing #define _GNU_SOURCE

On Mon, 09 Nov 2015, Geert Uytterhoeven wrote:

> On glibc 2.3.6:
> 
>     mlock2-tests.c: In function 'seek_to_smaps_entry':
>     mlock2-tests.c:158: warning: implicit declaration of function 'getline'
> 
> According to the manpage of getline(), it needs _GNU_SOURCE before glibc
> 2.10.
> 
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>

Acked-by: Eric B Munson <emunson@...mai.com>

> ---
>  tools/testing/selftests/vm/mlock2-tests.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/testing/selftests/vm/mlock2-tests.c b/tools/testing/selftests/vm/mlock2-tests.c
> index 4431994aade2ef6f..cb247219f1f72889 100644
> --- a/tools/testing/selftests/vm/mlock2-tests.c
> +++ b/tools/testing/selftests/vm/mlock2-tests.c
> @@ -1,3 +1,4 @@
> +#define _GNU_SOURCE
>  #include <sys/mman.h>
>  #include <stdint.h>
>  #include <stdio.h>
> -- 
> 1.9.1
> 

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)