linux-kernel - Re: [PATCH v3 11/32] scsi: hisi_sas: add phy SAS ADDR initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4369607.QVA3rBnZUm@wuerfel>
Date:	Mon, 09 Nov 2015 17:28:46 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	John Garry <john.garry@...wei.com>
Cc:	JBottomley@...n.com, robh+dt@...nel.org, pawel.moll@....com,
	mark.rutland@....com, ijc+devicetree@...lion.org.uk,
	galak@...eaurora.org, linux-scsi@...r.kernel.org,
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
	linuxarm@...wei.com, john.garry2@...l.dcu.ie, hare@...e.de,
	xuwei5@...ilicon.com, zhangfei.gao@...aro.org
Subject: Re: [PATCH v3 11/32] scsi: hisi_sas: add phy SAS ADDR initialization

On Tuesday 10 November 2015 00:32:16 John Garry wrote:
>  }
>  
> +static void hisi_sas_init_add(struct hisi_hba *hisi_hba)
> +{
> +       int i;
> +
> +       for (i = 0; i < hisi_hba->n_phy; i++)
> +               memcpy(&hisi_hba->phy[i].dev_sas_addr,
> +                      hisi_hba->sas_addr,
> +                      SAS_ADDR_SIZE);
> +}

I don't know the background here, but I thought it would have to
be a different address on each phy. Are you sure this is not the
case?

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/