linux-kernel - RE: [PATCH 8/9] Staging: lustre: llite

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 9 Nov 2015 19:18:16 +0000
From:	"Simmons, James A." <simmonsja@...l.gov>
To:	'Shivani Bhardwaj' <shivanib134@...il.com>,
	Michał Kępień <kernel@...pniu.pl>
CC:	"Drokin, Oleg" <oleg.drokin@...el.com>,
	Greg KH <gregkh@...uxfoundation.org>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	"Dilger, Andreas" <andreas.dilger@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 8/9] Staging: lustre: llite_lib: Remove wrapper function

>On Mon, Nov 9, 2015 at 7:07 PM, Michał Kępień <kernel@...pniu.pl> wrote:
>>> Remove the function ll_finish_md_op_data() and replace all its calls
>>> with the standrd function ll_finish_md_op_data().
>>
>> I believe you meant to write "standard function kfree()".
>>
>
>Yes. I am so sorry. Should I be sending the whole series again?
>Thank you
>Shivani

Yes please redo the series. I saw Oleg's concern and I would recommend that
besides the conversion to kfree that you add comments about what is being deleted.
I.E

/* Free struct md_op_data  data*/
kfree(...)