linux-kernel - Re: [PATCH] thermal: rockchip: fix compile error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151109193638.GB10824@localhost.localdomain>
Date:	Mon, 9 Nov 2015 11:36:39 -0800
From:	Eduardo Valentin <edubezval@...il.com>
To:	Caesar Wang <wxt@...k-chips.com>
Cc:	rui.zhang@...el.com, heiko@...ech.de, linux-kernel@...r.kernel.org,
	linux-rockchip@...ts.infradead.org, linux-pm@...r.kernel.org,
	sfr@...b.auug.org.au, lkp@...el.com
Subject: Re: [PATCH] thermal: rockchip: fix compile error

On Sun, Nov 08, 2015 at 09:40:43PM +0800, Caesar Wang wrote:
> Missing a include file caused compile error.
> 
> drivers/thermal/rockchip_thermal.c:
> In function 'rockchip_thermal_suspend':
> drivers/thermal/rockchip_thermal.c:720:2: error: implicit
> declaration of function 'pinctrl_pm_select_sleep_state'
> [-Werror=implicit-function-declaration]
> pinctrl_pm_select_sleep_state(dev);
>                  ^
> drivers/thermal/rockchip_thermal.c:
> In function 'rockchip_thermal_resume':
> drivers/thermal/rockchip_thermal.c:759:2: error: implicit
> declaration of function 'pinctrl_pm_select_default_state'
> [-Werror=implicit-function-declaration]
> ^pinctrl_pm_select_default_state(dev);
> cc1: some warnings being treated as errors
> 
> Fixes: 7e38a5b1daa1 ("thermal: rockchip: support the sleep pinctrl state
> to avoid glitches")


Adding this to my tree and sending to ruis too.


Thanks

> 
> Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
> Reported-by: kbuild test robot <lkp@...el.com>
> Signed-off-by: Caesar Wang <wxt@...k-chips.com>
> ---
> 
>  drivers/thermal/rockchip_thermal.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/thermal/rockchip_thermal.c b/drivers/thermal/rockchip_thermal.c
> index df28049..8928d67 100644
> --- a/drivers/thermal/rockchip_thermal.c
> +++ b/drivers/thermal/rockchip_thermal.c
> @@ -25,6 +25,7 @@
>  #include <linux/platform_device.h>
>  #include <linux/reset.h>
>  #include <linux/thermal.h>
> +#include <linux/pinctrl/consumer.h>
>  
>  /**
>   * If the temperature over a period of time High,
> -- 
> 1.9.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/