linux-kernel - Re: [PATCH] tree wide: Use kvfree() than conditional kfree()/vfree()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5253459.IxnqkcU2vL@vostro.rjw.lan>
Date:	Mon, 09 Nov 2015 22:48:37 +0100
From:	"Rafael J. Wysocki" <rjw@...ysocki.net>
To:	Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp>
Cc:	akpm@...ux-foundation.org, linux-mm@...ck.org,
	Russell King <linux@....linux.org.uk>,
	linux-acpi@...r.kernel.org, drbd-user@...ts.linbit.com,
	linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
	Oleg Drokin <oleg.drokin@...el.com>,
	Andreas Dilger <andreas.dilger@...el.com>,
	codalist@...a.cs.cmu.edu, linux-mtd@...ts.infradead.org,
	Jan Kara <jack@...e.com>, linux-fsdevel@...r.kernel.org,
	netdev@...r.kernel.org, Tony Luck <tony.luck@...el.com>,
	Boris Petkov <bp@...e.de>
Subject: Re: [PATCH] tree wide: Use kvfree() than conditional kfree()/vfree()

On Monday, November 09, 2015 08:56:10 PM Tetsuo Handa wrote:
> There are many locations that do
> 
>   if (memory_was_allocated_by_vmalloc)
>     vfree(ptr);
>   else
>     kfree(ptr);
> 
> but kvfree() can handle both kmalloc()ed memory and vmalloc()ed memory
> using is_vmalloc_addr(). Unless callers have special reasons, we can
> replace this branch with kvfree(). Please check and reply if you found
> problems.

ACK for the ACPI changes (and CCing Tony and Boris for the heads-up as they
are way more famailiar with the APEI code than I am).

Thanks,
Rafael

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/