linux-kernel - Re: [PATCH] staging: lustre: acl: fix ifnullfree.cocci warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.10.1511092157470.3844@hadrien>
Date:	Mon, 9 Nov 2015 22:04:40 +0000 (GMT)
From:	Julia Lawall <julia.lawall@...6.fr>
To:	Greg KH <gregkh@...uxfoundation.org>
cc:	kbuild test robot <lkp@...el.com>,
	Shivani Bhardwaj <shivanib134@...il.com>, kbuild-all@...org,
	andreas.dilger@...el.com, oleg.drokin@...el.com,
	lustre-devel@...ts.lustre.org, linux-kernel@...r.kernel.org,
	devel@...verdev.osuosl.org
Subject: Re: [PATCH] staging: lustre: acl: fix ifnullfree.cocci warnings



On Mon, 9 Nov 2015, Greg KH wrote:

> On Tue, Nov 10, 2015 at 03:43:50AM +0800, kbuild test robot wrote:
> > drivers/staging/lustre/lustre/llite/xattr.c:199:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.
> >
> >  NULL check before some freeing functions is not needed.
> >
> >  Based on checkpatch warning
> >  "kfree(NULL) is safe this check is probably not required"
> >  and kfreeaddr.cocci by Julia Lawall.
> >
> > Generated by: scripts/coccinelle/free/ifnullfree.cocci
> >
> > CC: Shivani Bhardwaj <shivanib134@...il.com>
> > Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
> > ---
> >
> >  xattr.c |    3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > --- a/drivers/staging/lustre/lustre/llite/xattr.c
> > +++ b/drivers/staging/lustre/lustre/llite/xattr.c
> > @@ -192,11 +192,10 @@ int ll_setxattr_common(struct inode *ino
> >  			 valid, name, pv, size, 0, flags,
> >  			 ll_i2suppgid(inode), &req);
> >  #ifdef CONFIG_FS_POSIX_ACL
> > -	if (new_value != NULL)
> >  		/*
> >  		 * Release the posix ACL space.
> >  		 */
> > -		kfree(new_value);
> > +	kfree(new_value);
>
> Looks like a bug in coccinelle, the comment line should also be indented
> to the left.
>
> Julia, any ideas?

I think it's on the border of what the person is going to have to resign
themselves to doing by hand.  I'm not sure which side of the border it is
on, but I try to focus more on getting the code printed in the right place
than on the comments.  I can check on it, though, and maybe an easy fix is
possible.

thanks,
julia
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/