linux-kernel - Re: [PATCH] mfd: wm8994: Add module description/author/license information

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151110101004.GH2549@ck-lbox>
Date:	Tue, 10 Nov 2015 10:10:04 +0000
From:	Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
To:	Peter Robinson <pbrobinson@...il.com>
CC:	Lee Jones <lee.jones@...aro.org>,
	<patches@...nsource.wolfsonmicro.com>,
	<linux-kernel@...r.kernel.org>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	<stable@...r.kernel.org>
Subject: Re: [PATCH] mfd: wm8994: Add module description/author/license
 information

On Sat, Nov 07, 2015 at 04:25:39PM +0000, Peter Robinson wrote:
> When compiled as a module we get a tainted kernel because of the lack
> of the module information and the following errors. Add details to
> fix the issue when wm8994_irq/wm8994_regmap are modular.
> 
> wm8994_irq: module license 'unspecified' taints kernel.
> 
> wm8994_irq: Unknown symbol irq_domain_xlate_twocell (err 0)
> wm8994_irq: Unknown symbol regmap_write (err 0)
> wm8994_irq: Unknown symbol gpiod_to_irq (err 0)
> wm8994_irq: Unknown symbol irq_modify_status (err 0)
> wm8994_irq: Unknown symbol irq_set_chip_and_handler_name (err 0)
> wm8994_irq: Unknown symbol regmap_add_irq_chip (err 0)
> wm8994_irq: Unknown symbol gpiod_get_raw_value_cansleep (err 0)
> wm8994_irq: Unknown symbol handle_nested_irq (err 0)
> wm8994_irq: Unknown symbol __irq_domain_add (err 0)
> wm8994_irq: Unknown symbol irq_create_mapping (err 0)
> wm8994_irq: Unknown symbol gpio_to_desc (err 0)
> wm8994_irq: Unknown symbol regmap_del_irq_chip (err 0)
> wm8994_regmap: module license 'unspecified' taints kernel.
> 
> Cc: <stable@...r.kernel.org>
> Signed-off-by: Peter Robinson <pbrobinson@...il.com>
> ---

This looks like the intention was for 8994 to be a single module
can you try the following and see if that also fixes your issue.

Thanks,
Charles

>From ba8cea5e6193c501070553f2f78d1ac59aae252d Mon Sep 17 00:00:00 2001
From: Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
Date: Tue, 10 Nov 2015 10:06:29 +0000
Subject: [PATCH] mfd: wm8994: Ensure that the whole MFD is built into a single module

Signed-off-by: Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
---
 drivers/mfd/Makefile |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile
index ef09bf1..b9c229d 100644
--- a/drivers/mfd/Makefile
+++ b/drivers/mfd/Makefile
@@ -63,7 +63,8 @@ wm8350-objs			:= wm8350-core.o wm8350-regmap.o wm8350-gpio.o
 wm8350-objs			+= wm8350-irq.o
 obj-$(CONFIG_MFD_WM8350)	+= wm8350.o
 obj-$(CONFIG_MFD_WM8350_I2C)	+= wm8350-i2c.o
-obj-$(CONFIG_MFD_WM8994)	+= wm8994-core.o wm8994-irq.o wm8994-regmap.o
+wm8994-objs			:= wm8994-core.o wm8994-irq.o wm8994-regmap.o
+obj-$(CONFIG_MFD_WM8994)	+= wm8994.o
 
 obj-$(CONFIG_TPS6105X)		+= tps6105x.o
 obj-$(CONFIG_TPS65010)		+= tps65010.o
-- 
1.7.2.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/