linux-kernel - Re: [PATCH v3 08/32] scsi: hisi_sas: add hisi_sas

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5641CD06.7030001@huawei.com>
Date:	Tue, 10 Nov 2015 10:55:02 +0000
From:	John Garry <john.garry@...wei.com>
To:	"fangwei (I)" <fangwei1@...wei.com>
CC:	"JBottomley@...n.com" <JBottomley@...n.com>,
	"robh+dt@...nel.org" <robh+dt@...nel.org>,
	"pawel.moll@....com" <pawel.moll@....com>,
	"mark.rutland@....com" <mark.rutland@....com>,
	"ijc+devicetree@...lion.org.uk" <ijc+devicetree@...lion.org.uk>,
	"galak@...eaurora.org" <galak@...eaurora.org>,
	"arnd@...db.de" <arnd@...db.de>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	"john.garry2@...l.dcu.ie" <john.garry2@...l.dcu.ie>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Linuxarm <linuxarm@...wei.com>, "hare@...e.de" <hare@...e.de>,
	"zhangfei.gao@...aro.org" <zhangfei.gao@...aro.org>
Subject: Re: [PATCH v3 08/32] scsi: hisi_sas: add hisi_sas_remove


>> +int hisi_sas_remove(struct platform_device *pdev)
>> +{
>> +	struct sas_ha_struct *sha = platform_get_drvdata(pdev);
>> +	struct hisi_hba *hisi_hba = sha->lldd_ha;
>> +
>> +	sas_unregister_ha(sha);
>> +	sas_remove_host(sha->core.shost);
>> +	scsi_remove_host(sha->core.shost);
>
> scsi host should be removed before detaching SAS transport.
>
> See more information:
> http://www.spinics.net/lists/linux-scsi/msg90088.html
>
> Thanks,
> Wei
>
OK, I can make this minor change.

Thanks,
John

>> +	hisi_sas_free(hisi_hba);
>> +	return 0;
>> +}
>> +EXPORT_SYMBOL_GPL(hisi_sas_remove);
>> +
>>   static __init int hisi_sas_init(void)
>>   {
>>   	pr_info("hisi_sas: driver version %s\n", DRV_VERSION);
>>
>
>
> .
>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/