linux-kernel - Re: [PATCH v2 5/7] ACPI / x86: introduce acpi_os

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VdeXWqcvrfYszjLj63zmZffRLh8ytGzSO+6d31TgbBaNw@mail.gmail.com>
Date:	Tue, 10 Nov 2015 15:04:28 +0200
From:	Andy Shevchenko <andy.shevchenko@...il.com>
To:	"Chen, Yu C" <yu.c.chen@...el.com>
Cc:	"Zheng, Lv" <lv.zheng@...el.com>, Lv Zheng <zetalog@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
	"Wysocki, Rafael J" <rafael.j.wysocki@...el.com>,
	"Brown, Len" <len.brown@...el.com>
Subject: Re: [PATCH v2 5/7] ACPI / x86: introduce acpi_os_readable() support

On Tue, Nov 10, 2015 at 11:42 AM, Chen, Yu C <yu.c.chen@...el.com> wrote:
> Hi, Lv
> Sorry for my late feedback on the patch, one minor nit below:

>> +     start_pfn = page_to_pfn(virt_to_page(pointer));
>> +     end_pfn = page_to_pfn(virt_to_page(pointer + length));
> Convert pointer to char* first?
> end_pfn = page_to_pfn(virt_to_page((char*)pointer + length));

Why do you need that?
void * + size_t = char * + size_t

-- 
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/