linux-kernel - Re: [PATCH] x86/fpu: Fix get_xsave_addr which returns error pointer to KVM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 10 Nov 2015 14:40:16 -0800
From:	Dave Hansen <dave.hansen@...el.com>
To:	Huaitong Han <huaitong.han@...el.com>, tglx@...utronix.de,
	mingo@...hat.com, hpa@...or.com
Cc:	x86@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/fpu: Fix get_xsave_addr which returns error pointer
 to KVM

On 11/06/2015 01:00 AM, Huaitong Han wrote:
> when KVM uses the get_xsave_addr, xsave parameter belongs to guest vcpu, if
> xsave is replaced with current task (host) xsave, get_xsave_addr will return error
> xsave addr to KVM.
> 
> Signed-off-by: Huaitong Han <huaitong.han@...el.com>

Looks good to me.  It was completely bogus that we passed 'xsave' in
there and then just wrote over it.

Reviewed-by: Dave Hansen <dave.hansen@...ux.intel.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/