linux-kernel - Re: [PATCH] KVM: x86: fix eflags state following processor init/reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 11 Nov 2015 14:34:06 +0800
From:	Wanpeng Li <kernellwp@...il.com>
To:	Paolo Bonzini <pbonzini@...hat.com>
Cc:	Nadav Amit <nadav.amit@...il.com>,
	Wanpeng Li <wanpeng.li@...mail.com>,
	kvm list <kvm@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] KVM: x86: fix eflags state following processor init/reset

2015-11-03 18:47 GMT+08:00 Paolo Bonzini <pbonzini@...hat.com>:
>
>
> On 28/10/2015 09:10, Nadav Amit wrote:
>> Here are my 5 cents. Note that vmx_vcpu_reset calls:
>>
>>       vmcs_writel(GUEST_RFLAGS, 0x02);
>>
>> (And the RFLAGS value is not cached by KVM, so no consistency problem should
>> occur.)
>>
>> You may want to change the value into constant or call a wrapper function
>> for setting RFLAGS, but I don’t see something broken in the functionality.
>
> I agree.  Wanpeng, if this is just a cleanup, can you send v2 that
> removes or modifies the existing call to vmcs_writel?  If there is a
> bug, can you write a unit test for it?  It should be possible to test
> for the problem using INIT+SIPI on an AP.

You are right, I write a INIT+SIPI kvm-unit-test and didn't trigger
any bug. Please ignore the patch.

Regards,
Wanpeng Li
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/