linux-kernel - Re: [PATCH v2] livepatch: x86: bugfix about kASLR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 11 Nov 2015 16:46:48 +0800
From:	Minfei Huang <mnfhuang@...il.com>
To:	Josh Poimboeuf <jpoimboe@...hat.com>
Cc:	Zhou Chengming <zhouchengming1@...wei.com>, sjenning@...hat.com,
	jkosina@...e.cz, vojtech@...e.cz, live-patching@...r.kernel.org,
	linux-kernel@...r.kernel.org, guohanjun@...wei.com,
	huawei.libin@...wei.com, xiexiuqi@...wei.com, cbay@...aysdata.com
Subject: Re: [PATCH v2] livepatch: x86: bugfix about kASLR

On 11/10/15 at 08:07am, Josh Poimboeuf wrote:
> On Fri, Nov 06, 2015 at 02:25:00PM +0800, Zhou Chengming wrote:
> > When enable KASLR, livepatch will adjust old_addr of changed
> > function accordingly. So do the same thing for reloc.
> > 
> > +
> > +#if defined(CONFIG_RANDOMIZE_BASE)
> > +			/* If KASLR has been enabled, adjust old value accordingly */
> > +			if (kaslr_enabled())
> > +				reloc->val += kaslr_offset();
> > +#endif
> >  			ret = klp_verify_vmlinux_symbol(reloc->name,
> >  							reloc->val);
> >  			if (ret)
> 
> Zhou, thanks a lot for this fix.
> 
> Generally I think this patch is fine.  However, Chris J Arges is working
> on another patch[*] which may get rid of reloc->val as an input and make
> this patch obsolete.
> 
> So, assuming Chris's patch eventually gets accepted, I don't see a need
> for this one unless anybody wants it as a bug fix for 4.4.
> 
> [*] https://lkml.kernel.org/r/1447085770-11729-1-git-send-email-chris.j.arges@canonical.com
> 

Hi, Josh.

I think Jessica Yu is working on the relative patchset which will
offload relocation logical to the module loader.

Thanks
Minfei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/