linux-kernel - [4.4 regression] 46a7fd8a : pcnet32: use pci_set_dma_mask insted of pci_dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 11 Nov 2015 08:50:40 +0000 (GMT)
From:	허종만 <jongman.heo@...sung.com>
To:	linux-kernel@...r.kernel.org, hch@....de, pcnet32@...ntier.com
Subject: [4.4 regression] 46a7fd8a : pcnet32: use pci_set_dma_mask insted of
 pci_dma_supported

Hi,

I'm using Fedora 23 Linux Guest on top of VMWare workstation (version 10), running on Windows 7 Host.

After pulling Merge branch 'akpm' from latest Linus git, my ethernet interface doesn't work.

From dmesg, I can see that pcnet32 doesn't support 32bit PCI busmaster DMA, as follows.

[    1.616867] libphy: Fixed MDIO Bus: probed
[    1.616871] pcnet32: pcnet32.c:v1.35 21.Apr.2008 tsbogend@...ha.franken.de
[    1.617232] pcnet32: architecture does not support 32bit PCI busmaster DMA
[    1.617304] VMware vmxnet3 virtual NIC driver - version 1.4.3.0-k-NAPI

Without the commit, pcnet32 ethernet is recognized correctly.

[    1.173395] libphy: Fixed MDIO Bus: probed
[    1.173399] pcnet32: pcnet32.c:v1.35 21.Apr.2008 tsbogend@...ha.franken.de
[    1.173637] pcnet32: PCnet/PCI II 79C970A at 0x2000, 00:0c:29:07:e2:51 assigned IRQ 19
[    1.173746] pcnet32: eth0: registered as PCnet/PCI II 79C970A
[    1.173799] pcnet32: 1 cards_found
[    1.173802] VMware vmxnet3 virtual NIC driver - version 1.4.2.0-k-NAPI

Below is git bisect log.

46a7fd8a9b302116b3263bc8e47f8f08c0d3a2ca is the first bad commit
commit 46a7fd8a9b302116b3263bc8e47f8f08c0d3a2ca
Author: Christoph Hellwig <hch@....de>
Date:   Tue Nov 10 14:45:17 2015 -0800

    pcnet32: use pci_set_dma_mask insted of pci_dma_supported

    All drivers should be using dma_set_mask / pci_set_dma_mask to try to
    set the dma mask instead of just querying it.  Without that some iommu
    implementations may not work.

    pci_dma_supported is removed entirely, but dma_supported stays for
    dma_ops implementations for now.

    This patch (of 15):

    This ensures the dma mask that is supported by the driver is recorded
    in the device structure.

    Signed-off-by: Christoph Hellwig <hch@....de>
    Acked-by: Don Fry <pcnet32@...ntier.com>
    Cc: "David S. Miller" <davem@...emloft.net>
    Cc: "James E.J. Bottomley" <jejb@...isc-linux.org>
    Cc: Alan Stern <stern@...land.harvard.edu>
    Cc: Alexandre Courbot <acourbot@...dia.com>
    Cc: Alexey Khoroshilov <khoroshilov@...ras.ru>
    Cc: Ben Skeggs <bskeggs@...hat.com>
    Cc: Christoph Hellwig <hch@....de>
    Cc: Daniel Vetter <daniel.vetter@...ll.ch>
    Cc: Dave Airlie <airlied@...hat.com>
    Cc: David Airlie <airlied@...ux.ie>
    Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
    Cc: Hans Verkuil <hverkuil@...all.nl>
    Cc: Helge Deller <deller@....de>
    Cc: Jiri Slaby <jslaby@...e.com>
    Cc: Mauro Carvalho Chehab <mchehab@....samsung.com>
    Cc: Pawel Osciak <pawel@...iak.com>
    Cc: Sakari Ailus <sakari.ailus@...ux.intel.com>
    Cc: Sergey Kozlov <serjk@...up.ru>
    Cc: Shradha Shah <sshah@...arflare.com>
    Cc: Solarflare linux maintainers <linux-net-drivers@...arflare.com>
    Cc: Steven Toth <stoth@...nellabs.com>
    Cc: Thierry Reding <treding@...dia.com>
    Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
    Signed-off-by: Linus Torvalds <torvalds@...ux-foundation.org>

:040000 040000 dd0a67b69180edc5243578c8504cd2bd5d4efe24 1f92cb3d86111d725f4cf6a84076e8d9eee04362 M	drivers

# git bisect log
git bisect start
# bad: [c5a37883f42be712a989e54d5d6c0159b0e56599] Merge branch 'akpm' (patches from Andrew)
git bisect bad c5a37883f42be712a989e54d5d6c0159b0e56599
# good: [ae36ce07abbdde3521dc0ef7e32143b88718cd21] Merge branch 'drm-fixes' of git://people.freedesktop.org/~airlied/linux
git bisect good ae36ce07abbdde3521dc0ef7e32143b88718cd21
# good: [be596aaa74090f553c61505ad03bb7a7460e5d23] Add current selection check.
git bisect good be596aaa74090f553c61505ad03bb7a7460e5d23
# good: [5dfe5b2c714a5bea0908c1e00da0e8e00535f55c] Merge branch 'misc' of git://git.kernel.org/pub/scm/linux/kernel/git/mmarek/kbuild
git bisect good 5dfe5b2c714a5bea0908c1e00da0e8e00535f55c
# bad: [111be8b28d87769dfbde901602d262902575805d] cx88: use pci_set_dma_mask insted of pci_dma_supported
git bisect bad 111be8b28d87769dfbde901602d262902575805d
# good: [3368e8fbcda539e4f9d6cdb750f23c25021698c9] lib/string.c: add ULL suffix to the constant definition
git bisect good 3368e8fbcda539e4f9d6cdb750f23c25021698c9
# bad: [bad007bca7b7643fea786737071c86088ba2803b] tw68-core: use pci_set_dma_mask insted of pci_dma_supported
git bisect bad bad007bca7b7643fea786737071c86088ba2803b
# bad: [46a7fd8a9b302116b3263bc8e47f8f08c0d3a2ca] pcnet32: use pci_set_dma_mask insted of pci_dma_supported
git bisect bad 46a7fd8a9b302116b3263bc8e47f8f08c0d3a2ca
# first bad commit: [46a7fd8a9b302116b3263bc8e47f8f08c0d3a2ca] pcnet32: use pci_set_dma_mask insted of pci_dma_supported