lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 11 Nov 2015 14:06:12 -0000 From: andreym@...eaurora.org To: "Christoph Hellwig" <hch@...radead.org> Cc: "Andrey Markovytch" <andreym@...eaurora.org>, tyhicks@...onical.com, ecryptfs@...r.kernel.org, linaz@...eaurora.org, "open list" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH v1] eCryptfs: enhancing eCryptfs to be used with external crypto engine > On Sun, Nov 08, 2015 at 10:10:00AM +0200, Andrey Markovytch wrote: >> +++ b/fs/ecryptfs/caches_utils.c >> @@ -0,0 +1,78 @@ >> +/* >> + * Copyright (c) 2015, The Linux Foundation. All rights reserved. > > Really? This looks like copy and paste from core code that defintively > was not written by the Linux Foundation. In addition this patch comes > from Qualcomm so something very fishy is going on here, which if I'd > call copyrght fraud if I'd want to be be mean. > > Please a) stop pointlessly copy and pasting code and b) have a word with > your lawyers on how to attribute code both that your wrote and which has > been copy and pasted. > Hi Christoph, Regarding the license, after double checking this, it seems that there has been a mistake and we unproperly attributed Linux copyright for the code that actually came from open source files having a different license. I appologise for that, I am checking this internally and will update patch with proper license. As for the 'pointless copy paste', the code was taken from files where those functions are declared as internal static, we had no choise but to copy paste them, other option would be alternating the original code and make those 2 functions public which seems unjustified in this case. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists